Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IS terms wording clearer when we fallback to vector.im #2760

Closed
manuroe opened this issue Oct 8, 2019 · 4 comments · Fixed by #2762
Closed

Make IS terms wording clearer when we fallback to vector.im #2760

manuroe opened this issue Oct 8, 2019 · 4 comments · Fixed by #2762
Labels
feature privacy privacy-sprint T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@manuroe
Copy link
Member

manuroe commented Oct 8, 2019

When the user has not set an IS yet, the app tries to use vector.im (or any url specified by the HS well-known or the one defined by identityserverurl in the app plist).
The issue is that the app falls back to it without any notice. vector.im terms are displayed to the end user without a clear context. Plus, they can appear from anywhere because of network latency.
This video shows the current confusing UX and the latency issue that makes terms appear a bit out of context

For the moment, we just want to improve the wording of the terms screen as a quick fix.
We should also let the user decide to not use any IS like riot-web does with the "Do not use an identity server" button in the settings in such condition.

The current terms screen (that can appear from nowhere):
image

@manuroe manuroe changed the title Make more IS terms wording clearer when we fallback to vector.im Make IS terms wording clearer when we fallback to vector.im Oct 8, 2019
@nadonomy
Copy link
Contributor

nadonomy commented Oct 8, 2019

Would it be possible to poll/check whether a user has granted permission ahead of time, so we can display this modal consent immediately after the user taps on something that requires consent?

@manuroe
Copy link
Member Author

manuroe commented Oct 9, 2019

@nadonomy not really. As this request is async, we can get the answer lately.

@manuroe
Copy link
Member Author

manuroe commented Oct 9, 2019

@nadonomy what do you think about the following screen?
This variant of the ToS screen will be displayed only in case where the user has not set an IS yet and when they enter in the people tab or when they want to invite people into a room.

Simulator Screen Shot - iPhone 7 - 2019-10-09 at 16 06 27

@nadonomy
Copy link
Contributor

nadonomy commented Oct 9, 2019

@manuroe can we use:

  • A title of "Contact discovery" to aid context quicker for users scanning/not really reading
  • Body text of "Accept the terms of the identity server (https://vector.im) to discover contacts." to exercise brevity
  • And "Decline" to exercise brevity again on the last button

manuroe added a commit that referenced this issue Oct 10, 2019
#2760

Add a outOfContext flag to ServiceTermsModal and adapt the display to it
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature privacy privacy-sprint T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants