Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification by DM: Improve scan code screen when there is only SAS verification action available #3035

Closed
SBiOSoftWhare opened this issue Mar 17, 2020 · 3 comments · Fixed by #3172
Closed

Verification by DM: Improve scan code screen when there is only SAS verification action available #3035

SBiOSoftWhare opened this issue Mar 17, 2020 · 3 comments · Fixed by #3172
Labels
X-Needs-Design May require input from the design team
Milestone
Sprint 28: Comple...

Comments

@SBiOSoftWhare
Copy link
Contributor

image
@manuroe manuroe added the X-Needs-Design May require input from the design team label Mar 17, 2020
@nadonomy
Copy link
Member

@manuroe thinking on this— why do we need to display a screen at all? Could the client not just go to/trigger emoji verification?

@nadonomy
Copy link
Member

After talking through on a call with @BillCarsonFr & @manuroe we concluded that the client could automatically trigger SAS verification, so for users the UX would just be [Verify] -> direct to comparing emojis.

@manuroe
Copy link
Member

manuroe commented Mar 26, 2020

This should be done only at app level by the code of this screen.

manuroe added a commit that referenced this issue Apr 28, 2020
@manuroe
Verification: Do not talk about QR code if only emoji is possible
ab1454f 
#3035
@manuroe manuroe mentioned this issue Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
X-Needs-Design May require input from the design team
Projects
None yet
Milestone
Sprint 28: Complete cross-signing
Development

Successfully merging a pull request may close this issue.

Verification: Do not talk about QR code if only emoji is possible element-hq/element-ios
3 participants
@SBiOSoftWhare @nadonomy @manuroe