Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice messages - Playback Mode #4094

Closed
2 tasks
gileluard opened this issue Mar 3, 2021 · 0 comments · Fixed by #4433
Closed
2 tasks

Voice messages - Playback Mode #4094

gileluard opened this issue Mar 3, 2021 · 0 comments · Fixed by #4433
Assignees
@stefanceriu
Labels
Sponsored

Comments

@gileluard
Copy link
Contributor

gileluard commented Mar 3, 2021 •
edited by giomfo

  • If the user taps the audio bar visualiser, or the recording goes off the limit of time, or if the recording is interrupted by an external event (phone call), the recordings stops and goes into Playback mode
  • In playback mode, the users can listen to the recordings, send the recordings or delete the recordings
@stefanceriu stefanceriu self-assigned this Jun 3, 2021
stefanceriu added a commit that referenced this issue Jun 22, 2021
@stefanceriu
#4094 - Added voice messages locked mode playback.
959ccc9
stefanceriu added a commit that referenced this issue Jun 22, 2021
@stefanceriu
#4094 - Fixed voice message toolbar states after sending message whil…
be8e0f6 
…e recording in locked mode.
stefanceriu added a commit that referenced this issue Jun 23, 2021
@stefanceriu
#4094 - Various tweaks, bug fixes and improvements following code rev…
fc7d311 
…iew.
stefanceriu added a commit that referenced this issue Jun 23, 2021
@stefanceriu
#4094 - Added multiple observation on media services and a mediaServi…
667d590 
…ceProvider that prevents simultaneous playback from multiple player instances.
stefanceriu added a commit that referenced this issue Jun 24, 2021
@stefanceriu
#4094 - Added multiple observation on media services and a mediaServi…
7d257f5 
…ceProvider that prevents simultaneous playback from multiple player instances.
stefanceriu added a commit that referenced this issue Jun 24, 2021
@stefanceriu
#4094 - Optimize expensive date formatters creation.
1b90b25
stefanceriu added a commit that referenced this issue Jun 24, 2021
@stefanceriu
#4094 - Added Opus Ogg support through FFmpegKit backed media convers…
aa60644 
…ion.
stefanceriu added a commit that referenced this issue Jun 24, 2021
@stefanceriu
#4094 - Added toast notifications and maximum recording duration.
c12a7dc
stefanceriu added a commit that referenced this issue Jun 25, 2021
@stefanceriu
#4094 - Added voice message attachment decryption, transcoding and sa…
acebef7 
…mpling caching layer.
stefanceriu added a commit that referenced this issue Jun 25, 2021
@stefanceriu
#4094 - Fixed improper weak display link targets.
24f06a7
stefanceriu added a commit that referenced this issue Jun 25, 2021
@stefanceriu
#4094 - Caching layer work queue fixes and preventing sampling divisi…
329215d 
…on by 0.
stefanceriu added a commit that referenced this issue Jun 25, 2021
@stefanceriu
#4094 - Fixed missing ffmpegkit module on release builds. Disabled ca…
2c80e61 
…che manager work queue for now as it's still not working properly.
stefanceriu added a commit that referenced this issue Jun 25, 2021
@stefanceriu
#4094 - Fixed toast notifications background color on dark themes.
fb87fe0
stefanceriu added a commit that referenced this issue Jun 25, 2021
@stefanceriu
#4094 - Increased minimum long press duration to 1 second, reversed a…
e0cbe49 
…udio recorder waveform direction, added a minimum recording duration of 5 seconds for hold&send.
This was referenced Jul 6, 2021
Merged
Merged
Merged
stefanceriu added a commit that referenced this issue Jul 12, 2021
@stefanceriu
#4094 - Reduced the minimum recording duration to 1 second.
7d1f33c
stefanceriu added a commit that referenced this issue Jul 12, 2021
@stefanceriu
#4094 - Updated english NSMicrophoneUsageDescription.
555fa5d
stefanceriu added a commit that referenced this issue Jul 12, 2021
@stefanceriu
#4094 - Disable message replies while recording audio messages.
9030f02
stefanceriu added a commit that referenced this issue Jul 12, 2021
@stefanceriu
#4094 - Fix crash on concurrent access to waveform audio samples.
ba54f91
stefanceriu added a commit that referenced this issue Jul 12, 2021
@stefanceriu
#4094 - Fixed attachments caching layer not working accordingly.
a5136a3
stefanceriu added a commit that referenced this issue Jul 13, 2021
@stefanceriu
#4094 - Sending voice message recording length and waveform samples.
2271973
stefanceriu added a commit that referenced this issue Jul 14, 2021
@stefanceriu
#4094 - Switched back to multiple audio player instances (1 per event…
1181cca 
… identifier), strongly retaining the currenty playing one and unloading all stopped ones. Various other improvements and bug fixes.
stefanceriu added a commit that referenced this issue Jul 14, 2021
@stefanceriu
#4094 - Fixed flickering elapsed time labels and other tweaks.
a3ec335
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4094 - Redrawing waveforms on bound changes.
521c713
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4094 - Reintroduced serial attachment loading processing queue and f…
9a3d26e 
…ixed completionCallback storage so they take the requestedNumberOfSamples into account.
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
Revert "#4094 - Reintroduced serial attachment loading processing que…
cf884c6 
…ue and fixed completionCallback storage so they take the requestedNumberOfSamples into account."

This reverts commit 9a3d26e.
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
Revert "Revert "#4094 - Reintroduced serial attachment loading proces…
427e77e 
…sing queue and fixed completionCallback storage so they take the requestedNumberOfSamples into account.""

This reverts commit cf884c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
Sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Voice messages element-hq/element-ios
2 participants
@stefanceriu @gileluard