Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resolution selection when sending image #4479

Closed
manuroe opened this issue Jun 25, 2021 · 8 comments · Fixed by #4721
Closed

Remove resolution selection when sending image #4479

manuroe opened this issue Jun 25, 2021 · 8 comments · Fixed by #4721
Assignees
Labels
parity-with-android parity-with-web X-Blocked X-Needs-Design May require input from the design team Z-Impact-3 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-3

Comments

@manuroe
Copy link
Member

manuroe commented Jun 25, 2021

Do we still need this v when sending an image?

IMG_6F55F62526F6-1

Element-Android doest not have it.
Plus, the implementation is currently buggy on iOS.

@manuroe manuroe added Z-Papercuts Visible. Impactful. Predictable to action. X-Needs-Design May require input from the design team parity-with-android parity-with-web labels Jun 25, 2021
@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Jun 25, 2021

Wait, is this Element iOS specific? for the longest time i just thought this was an iOS thing other apps opted out of.

If so, yes, but maybe pop it up when images start getting larger than 5 MB.

@ara4n
Copy link
Member

ara4n commented Jun 28, 2021

I'd like to keep this - I use it constantly to decide how much bandwidth to burn on a given image.

@manuroe manuroe added this to the iOS platform papercuts milestone Jun 28, 2021
@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Jun 28, 2021

Even though it would be kept, it would make a platform discrepancy between mobile clients (like manu said), maybe make it opt-in configurable?

@pixlwave
Copy link
Contributor

pixlwave commented Jul 8, 2021

Might it make sense to move the selection inline with the image preview? Similar to how Android has an option there for whether or not to compress a video (element-hq/element-android#3264).

@niquewoodhouse
Copy link

Might it make sense to move the selection inline with the image preview? Similar to how Android has an option there for whether or not to compress a video (vector-im/element-android#3264).

Compressing things to some degree sounds really reasonable to me. The only issue might be that, as we support iPad, we might need to be aware of how things look on a 12.9" phone. From the link, I can't work out what defines when something is too big to be uploaded?

I'd like to keep this - I use it constantly to decide how much bandwidth to burn on a given image.

It sounds like in this insight, the user is deciding themselves, so it feels like the system decided when something is too big is maybe not appropriate? When I try to send an email with an attachment on iOS sometimes I get something like the below image, but not sure who is deciding what's too large.

maybe make it opt-in configurable?

To me, that sounds reasonable. There could be a data-friendly mode or something that could include a few things:

  • Ask you to confirm the upload file size
  • Don't auto play stuff
  • etc

@niquewoodhouse
Copy link

After a brief design exploration of the issue we came to some solutions:

  • Add a setting in a new section (Media) that is off by default

if settings route@2x

This follows @ShadowJonathan's suggestion that people can opt-into this if they want the resolution selection to persist.

  • Alter the confirm screen to include file size option

Would give people (harder) access to the option if they needed it, but make the flow easier for most users who don't want to edit size.

selector-01b

We did consider some other ideas, but they expanding the work more than we probably require at this stage.

selector-02

@niquewoodhouse
Copy link

Just thinking slightly longer-term for this, it might be that we have a low-quality mode that just auto-sends at small file sizes:

Settings - low quality mode@2x

Or we have more detailed settings section that includes a low-quality mode option + an always confirm option for people who insist on picking the size themselves.

Settings - unique page@2x

@pixlwave
Copy link
Contributor

Just thinking slightly longer-term for this, it might be that we have a low-quality mode that just auto-sends at small file sizes:

Or we have more detailed settings section that includes a low-quality mode option + an always confirm option for people who insist on picking the size themselves.

Ok yep interesting ideas. Both sound potentially good options to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parity-with-android parity-with-web X-Blocked X-Needs-Design May require input from the design team Z-Impact-3 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants