Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call: The "Return to call" banner does not rotate with the device #482

Closed
manuroe opened this issue Jul 28, 2016 · 2 comments
Closed

Call: The "Return to call" banner does not rotate with the device #482

manuroe opened this issue Jul 28, 2016 · 2 comments
Assignees
@giomfo
Labels
P1
Milestone
sprint3

Comments

@manuroe
Copy link
Member

manuroe commented Jul 28, 2016 •
edited

The banner color should also follow the Vector color scheme
@manuroe manuroe added the P2 label Aug 3, 2016
@manuroe manuroe added this to the sprint2.2 milestone Aug 3, 2016
manuroe added a commit that referenced this issue Aug 9, 2016
@manuroe
"Return to call" banner: Use the Vector green for the background #482
75feee9
@manuroe
Copy link
Member Author

manuroe commented Aug 9, 2016

The current banner does not follow the expected design of the "Active Call" banner (see #500).
iOS will automatically rotate such banner.

@manuroe manuroe closed this as completed Aug 9, 2016
@giomfo giomfo reopened this Aug 22, 2016
@giomfo giomfo modified the milestones: sprint3, sprint2.2 Aug 22, 2016
@giomfo giomfo added P1 and removed P2 labels Aug 22, 2016
@giomfo
Copy link
Member

giomfo commented Aug 22, 2016 •
edited

Set hangup icon in pink red in the current room history

  • Disable call option in other rooms

giomfo added a commit that referenced this issue Sep 2, 2016
@giomfo
Bug Fix - Call: The "Return to call" banner does not rotate with the …
00cb861 
…device

#482

+ handle correclty hangup button in room options menu
@giomfo giomfo mentioned this issue Sep 2, 2016
Merged
@giomfo giomfo closed this as completed Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giomfo giomfo

Labels
P1
Projects
None yet
Milestone
sprint3
Development

No branches or pull requests
2 participants
@manuroe @giomfo