New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate and use localizable strings in the MatrixKit and Element (swift & objc) #4899

Closed

stefanceriu opened this issue Sep 24, 2021 · 1 comment

Assignees

Contributor

stefanceriu commented Sep 24, 2021

For ease of use and compile time safety we would like to start using swiftgen to generate localizable strings in the MatrixKit as well, similarly to what's done in Element.

stefanceriu self-assigned this

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Generating localizable strings. …

90848ff

…Renamed "copy" to "copy_button_name" to avoid ObjC method name conflicts.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Generating localizable strings. …

35c2337

…Renamed "copy" to "copy_button_name" to avoid ObjC method name conflicts.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Generating localizable strings. …

7fc3446

…Renamed "copy" to "copy_button_name" to avoid ObjC method name conflicts.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Replaced all `[NSBundle mxk_loca…

d5df3dc

…lizedStringForKey]` usages with newly generated `MatrixKitL10n`

stefanceriu changed the title ~~Generate localizable strings in the MatrixKit~~ Generate and use localizable strings in the MatrixKit and Element (swift & objc)

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Generating localizable strings. …

868565b

…Renamed "copy" to "copy_button_name" to avoid ObjC method name conflicts.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Replaced (*almost*) all `[NSBund…

37ebb1f

…le mxk_localizedStringForKey]` usages with newly generated `MatrixKitL10n`

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Replaced (*almost*) all `[NSBund…

a656d33

…le mxk_localizedStringForKey]` usages with newly generated `MatrixKitL10n`

stefanceriu added a commit that referenced this issue


          /issues/4899 - Replaced (*almost*) all NSLocalizedString calls with n…

f721482

…ewly generated ObjC methods.

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

710b784

stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

8b8863d

…safety to room name and send reply event localizable strings.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

37b3165

…safety to room name and send reply event localizable strings.

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

6abcc5e

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Localized and generated missing …

…strings.

stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

9214eb2

…safety to room name and send reply event localizable strings.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Localized and generated missing …

a295ea2

…strings.

stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

a6a5186

…safety to room name and send reply event localizable strings.

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

6ff2bbb

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Localized and generated missing …

0f27301

…strings.

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

931b245

stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

d8135b7

…safety to room name and send reply event localizable strings.

stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

6e0caf9

…safety to room name and send reply event localizable strings.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Generating localizable strings. …

19ca6d5

…Renamed "copy" to "copy_button_name" to avoid ObjC method name conflicts.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Replaced (*almost*) all `[NSBund…

4b0eb7b

…le mxk_localizedStringForKey]` usages with newly generated `MatrixKitL10n`

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Added dynamism and compile time …

5aef223

…safety to room name and send reply event localizable strings.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - Localized and generated missing …

ec35af8

…strings.

stefanceriu added a commit that referenced this issue


          /issues/4899 - Replaced (*almost*) all NSLocalizedString calls with n…

…ewly generated ObjC methods.

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

2c0bf1e

stefanceriu closed this as completed

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

7da4c70

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

529defe

stefanceriu added a commit that referenced this issue


          /issues/4899 - Fixed various localization issues.

d6ffc55

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - MXKEventFormatter: Fixed invalid…

ca1988d

… parameters passed to generated localization functions.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - MXKEventFormatter: Fixed invalid…

5e5d3b5

… parameters passed to generated localization functions.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - MXKEventFormatter: Fixed invalid…

88595c8

… parameters passed to generated localization functions.

stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue


          element-hq/element-ios/issues/4899 - MXKEventFormatter: Fixed invalid…

7403ecf

… parameters passed to generated localization functions.

ghost commented Feb 18, 2023

Hi there. Sorry if it's the wrong topic, but as it all is dedicated to MXSendReplyEventStringLocalizerProtocol, maybe you can help a newbie?)

I cloned the latest Element iOS master, when trying to build it in xCode, I'm getting the following. Don't have any ideas how to fix it and why it's appearing. Because I didn't yet change anything within the project, just trying to build the stock version as it is to test.

An advise would be highely appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment