Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Localizable strings #5325

Open
stefanceriu opened this issue Dec 20, 2021 · 1 comment
Open

Merge Localizable strings #5325

stefanceriu opened this issue Dec 20, 2021 · 1 comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
Issue triage

Comments

@stefanceriu
Copy link
Contributor

In Element, we currently have 3 localization file schemes:

  1. Vector.strings - main application translations
  2. MatrixKit.strings - translation migrated from the MatrixKit
  3. Localizable.strings - strings used only in the notification extension

We should merge all of them together into Vector and clean up Weblate.
While merging the MatrixKit ones in is rather straight forward for 3) we will need to migrate from the localizedUserNotificationString method (which seems to only be useful for scheduled local notifications) to a normal swiftgen template one.
@stefanceriu stefanceriu added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 20, 2021
@stefanceriu stefanceriu self-assigned this Dec 20, 2021
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 20, 2021
@pixlwave pixlwave added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 11, 2022
@pixlwave
Copy link
Contributor

We should merge all of them together into Vector and clean up Weblate.

What would be the benefit of picking Vector.strings over Xcode's standard Localizable.strings?

@pixlwave pixlwave moved this from Incoming to Triaged in Issue triage Jan 11, 2022
@pixlwave pixlwave mentioned this issue Mar 3, 2022
Merged
@stefanceriu stefanceriu removed their assignment Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
Issue triage
Triaged
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @pixlwave