Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image sent to encrypted room was not encrypted #5564

Closed
noantiq opened this issue Feb 11, 2022 · 2 comments · Fixed by #5567 or matrix-org/matrix-ios-sdk#1369
Closed

Image sent to encrypted room was not encrypted #5564

noantiq opened this issue Feb 11, 2022 · 2 comments · Fixed by #5567 or matrix-org/matrix-ios-sdk#1369
Assignees
@manuroe
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Issue triage

Comments

@noantiq
Copy link
Contributor

noantiq commented Feb 11, 2022

Steps to reproduce

  1. Open an encrypted room
  2. press button to send an image
  3. give access to all pictures (recently re-installed the app)
  4. select an image and sent it

Outcome

What did you expect?

Image gets encrypted and sent to the room.

What happened instead?

  • Image was not encrypted but sent to the room.
  • A red shield with an exclamation mark appeared next to the image
  • When clicking the red shield the E2EE info reads as following:

Curve25519 identity key
none

Claimed Ed25519 fingerprint key
none

Algorithm
unencrypted

Session ID
none

Sender session information

unknown session

Your phone model

iPhone 8

Operating system version

iOS 15.3

Application version

Element 1.8.0

Homeserver

Synapse 1.52.0

Will you send logs?

Yes
@noantiq noantiq added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 11, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Feb 11, 2022
@pixlwave pixlwave added A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 11, 2022
@pixlwave pixlwave linked a pull request Feb 11, 2022 that will close this issue
Fix for images sometimes being sent unencrypted in an encrypted room. #5567
Merged
@pixlwave pixlwave moved this from Incoming to Triaged in Issue triage Feb 14, 2022
@noantiq
Copy link
Contributor Author

noantiq commented Feb 14, 2022

Just happened again (in a DM), I sent logs again mentioning this issue.

@manuroe manuroe self-assigned this Feb 15, 2022
@manuroe manuroe mentioned this issue Feb 15, 2022
Merged
@manuroe
Copy link
Member

manuroe commented Feb 17, 2022

Thanks @noantiq for this report. 1.8.1 is safe now.

@manuroe manuroe closed this as completed Feb 17, 2022
Issue triage automation moved this from Triaged to Closed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Issue triage
Closed
Milestone
No milestone
3 participants
@pixlwave @manuroe @noantiq