Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently edited message from the past is not visible #5835

Closed
Anderas opened this issue Mar 16, 2022 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#1408
Closed

Recently edited message from the past is not visible #5835

Anderas opened this issue Mar 16, 2022 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#1408
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@Anderas
Copy link
Contributor

Anderas commented Mar 16, 2022

Steps to reproduce

  1. Open a room where some message from the past has not yet been loaded via pagination
  2. Edit this message on another client
  3. Paginate to this message on the first device

=> The message is not shown at all

The root cause of this behaviour is the implementation of replay attack prevention. Given that the original event as well as the edit event now have the same content, Olm will recieve the same ciphertext and return the same message index. We now have two identical decrypted messages, one of which will be ignored by the replay attack prevention. If the first event happens to be the edit and the second the original, the client will never show any message at all, because it is ignored.

Outcome

What did you expect?

The edited message is visible

What happened instead?

The edited message is missing

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@Anderas Anderas added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 16, 2022
@Anderas
Copy link
Contributor Author

Anderas commented Mar 16, 2022

Partially related to #4329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
1 participant