Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Apple context menus in matrix items list screens #5953

Closed
Tracked by #5627
gileluard opened this issue Mar 31, 2022 · 2 comments · Fixed by #5963
Closed
Tracked by #5627

Add support for Apple context menus in matrix items list screens #5953

gileluard opened this issue Mar 31, 2022 · 2 comments · Fixed by #5963
Assignees
@gileluard
Labels
T-Other Questions, user support, anything else Z-IA Issues relating to information architecture Z-Labs
Projects
Issue triage

Comments

@gileluard
Copy link
Contributor

gileluard commented Mar 31, 2022 •
edited

Hypothesis

Following Apple's HIG where possible we help people know how to navigate and use Element on iOS.

Proposal

Support context menus where people might expect them, eg

  • Room tile in a tabs/home
  • Room tile in search screens

Examples

Room tile on tab

On a tab, currently a long press leads to a different background for the relevant room tile.

Control

Control_Tab@2x

Idea 1

Context menu_tab1@2x

Idea 2

Context menu_tab2@2x
@gileluard gileluard added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 31, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Mar 31, 2022
@gileluard gileluard added T-Other Questions, user support, anything else Z-Labs Z-IA Issues relating to information architecture labels Mar 31, 2022
@gileluard gileluard moved this from Incoming to Triaged in Issue triage Mar 31, 2022
@gileluard gileluard removed the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 31, 2022
@gileluard gileluard self-assigned this Mar 31, 2022
@gileluard
Copy link
Contributor Author

gileluard commented Mar 31, 2022 •
edited

@nadonomy @kittykat @amshakal here are the possible context menu with previews we could have:

  • Home
    ezgif-2-374b142ca5

  • Favourite
    ezgif-2-abe7b36cd8

  • People
    ezgif-2-b2f51a7eea

  • Rooms
    ezgif-2-0302f0d7b6

@gileluard
Copy link
Contributor Author

Also I managed to use the fancy custom navigation animation provided by Apple when the user taps the preview
ezgif-2-151dcc94c8

@gileluard gileluard mentioned this issue Mar 31, 2022
Closed
5 tasks
gileluard added a commit that referenced this issue Apr 3, 2022
@gileluard
Add support for Apple context menus in matrix items list screens #5953
6767a05 
- Done
This was referenced Apr 3, 2022
Merged
Merged
gileluard added a commit that referenced this issue Apr 3, 2022
@gileluard
Add support for Apple context menus in matrix items list screens #5953
4cc19e3 
- Added changelog
gileluard added a commit that referenced this issue Apr 4, 2022
@gileluard
Add support for Apple context menus in matrix items list screens #5953
7e8deea 
- Code tweaks
Issue triage automation moved this from Triaged to Closed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
T-Other Questions, user support, anything else Z-IA Issues relating to information architecture Z-Labs
Projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Apple context menus in matrix items list screens element-hq/element-ios
1 participant
@gileluard