Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use contains_url filter for navigating files and showing a file index for a room #652

Closed
ara4n opened this issue Sep 25, 2016 · 4 comments
Closed

Use contains_url filter for navigating files and showing a file index for a room #652

ara4n opened this issue Sep 25, 2016 · 4 comments
Assignees
@giomfo
Labels
P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@ara4n
Copy link
Member

ara4n commented Sep 25, 2016

No description provided.

@ylecollen
Copy link

To search medias, there is a new dedicated parameter "contains_url".

see
https://github.com/matrix-org/matrix-android-sdk/blob/develop/matrix-sdk/src/main/java/org/matrix/androidsdk/rest/client/EventsRestClient.java#L296

@giomfo giomfo self-assigned this Sep 27, 2016
@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements feature P1 labels Sep 27, 2016
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 3, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
c9d8361 
…file index for a room.

element-hq/element-ios#652
@giomfo giomfo mentioned this issue Oct 3, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Oct 3, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
a2ed3f2 
…file index for a room.

element-hq/element-ios#652
@giomfo giomfo mentioned this issue Oct 3, 2016
Merged
giomfo added a commit that referenced this issue Oct 3, 2016
@giomfo
Use contains_url filter for navigating files and showing a file index…
4d1335b 
… for a room.

#652
@giomfo giomfo mentioned this issue Oct 3, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 5, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
7d192ed 
…file index for a room.

element-hq/element-ios#652

MXRestClient: Support 3 filtering modes on attachments during the messages search (see `MXMessagesSearchMediaFilter`):
- Default value. No limitation.
- Only the messages which contain an URL are concerned by the search request.
- The messages which contain an URL are not concerned by the search request.
@giomfo giomfo mentioned this issue Oct 5, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Oct 5, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
8a89bbe 
…file index for a room.

element-hq/element-ios#652

MXRestClient: Support 3 filtering modes on attachments during the messages search (see `MXMessagesSearchMediaFilter`):
- Default value. No limitation.
- Only the messages which contain an URL are concerned by the search request.
- The messages which contain an URL are not concerned by the search request.
@giomfo giomfo mentioned this issue Oct 5, 2016
Merged
giomfo added a commit that referenced this issue Oct 5, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
8263ae0 
…file index for a room

#652

Support file search at room level.
@giomfo giomfo mentioned this issue Oct 5, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 6, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
37488ea 
…file index for a room.

element-hq/element-ios#652

MXRestClient: Define 'MXRoomEventFilter' object to handle room event filtering in server request.
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Oct 6, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
4693c4b 
…file index for a room.

element-hq/element-ios#652

- Use the MXRoomEventFilter object
giomfo added a commit that referenced this issue Oct 6, 2016
@giomfo
Bug Fix - Use contains_url filter for navigating files and showing a …
d12bf98 
…file index for a room

#652

Support file search at room level.
@giomfo
Copy link
Member

giomfo commented Oct 12, 2016

Fixed
The contains_url filter is now used in case of search (global search and room data search).
It is not used for showing a file index for a room because we are using the local storage of the room data by keeping update the storage for all the room data (not only the attachments).

@giomfo giomfo closed this as completed Oct 12, 2016
@giomfo giomfo reopened this Nov 16, 2016
@giomfo
Copy link
Member

giomfo commented Nov 16, 2016

The contains_url filter must be used for showing a file index for a room.

@giomfo giomfo removed the feature label Nov 16, 2016
@giomfo
Copy link
Member

giomfo commented Nov 25, 2016

Closed: an issue was created for this second point: #720.

@giomfo giomfo closed this as completed Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giomfo giomfo

Labels
P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @giomfo @ylecollen