Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unread_thread_notifications shouldn't be sent if the home server doesn't support notifications per threads #7066

Closed
gileluard opened this issue Nov 10, 2022 · 0 comments · Fixed by #7067
Closed

unread_thread_notifications shouldn't be sent if the home server doesn't support notifications per threads #7066

gileluard opened this issue Nov 10, 2022 · 0 comments · Fixed by #7067
Assignees
@gileluard
Labels
A-Threads Message threading to simplify the Timeline T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
Issue triage

Comments

@gileluard
Copy link
Contributor

Steps to reproduce

  1. Sign in with a user against matrix.org

Outcome

What did you expect?

As matrix.org doesn't support yet notifications per thread, the application should add unread_thread_notifications as part of sync filter.

What happened instead?

the application sends unread_thread_notifications the parameters even if the home server doesn't support notifications per threads

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@gileluard gileluard added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Nov 10, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Nov 10, 2022
@gileluard gileluard self-assigned this Nov 10, 2022
@gileluard gileluard added A-Threads Message threading to simplify the Timeline Z-Labs labels Nov 10, 2022
@gileluard gileluard moved this from Incoming to Triaged in Issue triage Nov 10, 2022
This was referenced Nov 10, 2022
Merged
Merged
Issue triage automation moved this from Triaged to Closed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Threads Message threading to simplify the Timeline T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Threads: removed "unread_thread_notifications" from sync filters element-hq/element-ios
1 participant
@gileluard