Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks to a room/space should be pills #7409

Closed
giomfo opened this issue Mar 6, 2023 · 1 comment
Closed

Permalinks to a room/space should be pills #7409

giomfo opened this issue Mar 6, 2023 · 1 comment
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Mar 6, 2023

Part of element-hq/element-meta#1030

When a room's link (matrix.to or custom base url) is sent to the timeline, it should not show as the URL but instead the pill.

The pill should show the room/spaces avatar and name, like this: Screenshot 2023-02-21 at 18 13 11
If this is not possible, because the user does not have access to the room name or avatar, the pill should show the default room icon and "Room/Space". Like this: image

Note: About this last case, if the room's link provides an alias, we should display it by default (instead of "room"), the avatar will display then a #)

Note2: the avatar and the room name may be retrieved by using the Room summary API

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 6, 2023
@RiotRobot RiotRobot added this to Incoming in Issue triage Mar 6, 2023
@giomfo giomfo moved this from Incoming to Triaged in Issue triage Mar 6, 2023
nimau added a commit that referenced this issue Mar 17, 2023
#7409: Permalinks to a room/space are pillified
#7411: Permalinks to a matrix user are pillified
#7412: Permalinks to messages are pillified
nimau added a commit that referenced this issue Mar 17, 2023
#7409: Permalinks to a room/space are pillified
#7411: Permalinks to a matrix user are pillified
#7412: Permalinks to messages are pillified
@giomfo
Copy link
Member Author

giomfo commented Mar 22, 2023

Done v1.10.6

@giomfo giomfo closed this as completed Mar 22, 2023
Issue triage automation moved this from Triaged to Closed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
Development

No branches or pull requests

2 participants