Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks to messages should be pillified #7412

Closed
giomfo opened this issue Mar 6, 2023 · 1 comment
Closed

Permalinks to messages should be pillified #7412

giomfo opened this issue Mar 6, 2023 · 1 comment
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Mar 6, 2023

Part of element-hq/element-meta#1030

We decided to not pillify permalinks to message when they have been sent formatted (markdown).
The following changes will be applied on permalinks to message only if they are not sent formatted:

Permalinks to a message in the same room

  • When a user has shared a permalink to a message in the same room,
it should show like this: image
If we failed to retrieve the event or the sender details, just show "Message" as a pill with the link icon image

Permalinks to a message in a different room

  • When a user has shared a permalink to a message in another room
it should show like this (with the avatar and room name): image
If these are not available, apply the same logic as above (the pill should show the default room icon and "Room") image

Note2: the avatar and the room name may be retrieved by using the Room summary API

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 6, 2023
@RiotRobot RiotRobot added this to Incoming in Issue triage Mar 6, 2023
@giomfo giomfo moved this from Incoming to Triaged in Issue triage Mar 7, 2023
nimau added a commit that referenced this issue Mar 17, 2023
#7409: Permalinks to a room/space are pillified
#7411: Permalinks to a matrix user are pillified
#7412: Permalinks to messages are pillified
nimau added a commit that referenced this issue Mar 17, 2023
#7409: Permalinks to a room/space are pillified
#7411: Permalinks to a matrix user are pillified
#7412: Permalinks to messages are pillified
@giomfo
Copy link
Member Author

giomfo commented Mar 22, 2023

Done v1.10.6

Note: the same fallback pill has been used for both cases (permalink to a message in a different room and permalink to a message in the same room).
image

@giomfo giomfo closed this as completed Mar 22, 2023
Issue triage automation moved this from Triaged to Closed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
Development

No branches or pull requests

2 participants