Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Creation Intro Cell does not transition from Light to Dark Mode and back #7554

Closed
mgcm opened this issue May 23, 2023 · 1 comment
Closed
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mgcm
Copy link
Contributor

mgcm commented May 23, 2023

Steps to reproduce

  1. Log in to Element iOS
  2. Create a new room or select a room with little to no history in the timeline
  3. See the empty timeline and the room creation intro cell in the top
  4. Put the app into the background
  5. Wait until there is a theme change from Dark to Light or Light to Dark or force a change in system settings
  6. Go back into Element and you will see that all of the UI components have changed its theme except the top room creation intro header cell

Outcome

What did you expect?

All the UI components should update its themeing without having to leave the room or restart the app

What happened instead?

The Room Creation Intro cell does not adjust its theme to the active system theme when it changes without leaving the timeline view.

See the attached GIF animation:

element-ios-timeline-theme-bug

Your phone model

All iPhones

Operating system version

iOS 14+

Application version

develop branch

Homeserver

not relevant

Will you send logs?

No

@mgcm mgcm added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 23, 2023
@RiotRobot RiotRobot added this to Incoming in Issue triage May 23, 2023
@mgcm
Copy link
Contributor Author

mgcm commented May 23, 2023

PR #7555 fixes this

@Velin92 Velin92 closed this as completed May 24, 2023
Issue triage automation moved this from Incoming to Closed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Development

No branches or pull requests

2 participants