Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt the user when the invited MatrixId is not recognized #7558

Closed
giomfo opened this issue May 25, 2023 · 0 comments
Closed

Prompt the user when the invited MatrixId is not recognized #7558

giomfo opened this issue May 25, 2023 · 0 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@giomfo
Copy link
Member

giomfo commented May 25, 2023

Steps to reproduce

Scenario 1:

  • Start a new DM by filling a non-existent MatrixId

Scenario 2:

  • Open an existing group chat
  • Invite a new member by filling a non-existent MatrixId

Outcome

What did you expect?

When the MXID is not recognised (= the getProfile failed (for example: M_NOT_FOUND error, or 502 code) we should present a pop-up similar to the web client:
Screenshot 2023-05-24 at 09 50 54

What happened instead?

Scenario1 : I got an error which prevented me from starting anyway the DM
Screenshot 2023-05-25 at 08 57 27

-> we should replace this error by the following alert:
title: "Confirmation"
message: "Unable to find profiles for this Matrix ID. Would you like to start a DM anyway?"
actions: "Cancel" / "Start DM anyway"

Scenario2: I had to confirm that I wish to invite the new user to a room
Screenshot 2023-05-25 at 11 57 24

-> we should keep this "Confirmation" dialog by updating it when the mxId is unrecognised
title: "Confirmation"
message: "Unable to find profiles for this Matrix ID. Are you sure..."
actions: "Cancel" / "Invite anyway"

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@giomfo giomfo added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 25, 2023
@RiotRobot RiotRobot added this to Incoming in Issue triage May 25, 2023
@giomfo giomfo added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely Sponsored labels May 25, 2023
@pixlwave pixlwave removed this from Incoming in Issue triage May 31, 2023
@giomfo giomfo closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

1 participant