Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars (and probably other media) do not display with account on a self-signed server #816

Closed
manuroe opened this issue Nov 22, 2016 · 13 comments
Assignees

Comments

@manuroe
Copy link
Member

manuroe commented Nov 22, 2016

https://matrix.to/#/!tDRGDwZwQnlkowsjsm:matrix.org/$1479806434848416Rbrux:matrix.org

@rnhmjoj
Copy link

rnhmjoj commented Jan 30, 2017

I can confirm that all media does not load. Also the app keeps on reloading every couple of seconds so you have the spinning animation constantly displayed everywhere.

@madduck
Copy link

madduck commented Feb 17, 2017

I am experiencing the same problem, though the server's certs are CAcert-issued (not self-signed).

It does not matter whether I give Riot permission to trust the certificate, or install the CAcert certificate profile into iOS.

Probably the issue lies deep inside some Apple black box which fails (or refuses) to work with officially sanctioned certificate authorities.

cc. @mjollnir

@manuroe manuroe self-assigned this Feb 17, 2017
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Feb 17, 2017
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Feb 17, 2017
…t display with account on a self-signed server (element-hq/element-ios#816)

Handle this by storing allowed certificates into a singleton that the static MXMediaManager can use.
@manuroe manuroe closed this as completed Feb 20, 2017
@edam
Copy link

edam commented Jul 7, 2017

This issue is still present on v0.4.3. Specifically, client connects to a server with self-signed cert. No media is displayed. It was the same with v0.3.13 (on app store previously; updated today).

@giomfo
Copy link
Member

giomfo commented Jul 11, 2017

@edam: I tested it again, and I did not reproduce it on a self-signed server.

@edam
Copy link

edam commented Jul 11, 2017

Hi @giomfo, thanks for taking a look! Problem is definitely there, and was with v0.3.13 too. There is no media shown, and server has self-signed cert (although this is possibly not relevant).

Can I help diagnose the problem? I'm a developer myself, but the phone is a friend's and I am not familiar with iOS myself. Would it help if I created an account for you on the server for you to test the client against? Would if help to know what version of iOS the device is running?

@edam
Copy link

edam commented Jul 11, 2017

@giomfo: platform is iOS v10.3.2 on iPhone 6s.

@edam
Copy link

edam commented Jul 19, 2017

Pinging. 🙂

Would you like me to set up an account on the server that this issue occurs on to help diagnose the issue in the client?

@giomfo giomfo reopened this Jul 19, 2017
@giomfo
Copy link
Member

giomfo commented Jul 19, 2017

@edam: Yes please (you may send this account credentials in a PM to @Giom:matrix.org

@manuroe
Copy link
Member Author

manuroe commented Jul 19, 2017

May be solved by matrix-org/matrix-ios-sdk#332

@edam
Copy link

edam commented Jul 19, 2017

@giom: PMed!

@edam
Copy link

edam commented Jul 19, 2017

@manuroe: matrix-org/matrix-ios-sdk#332 would seem to describe the problem accurately. The self-signed cert was accepted by the user, and all but media downloads work.

@giomfo
Copy link
Member

giomfo commented Jul 19, 2017

I reproduced the issue with the provided account.
(matrix-org/matrix-ios-sdk#332 does not fix it)

Investigation is in progress

giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 19, 2017
…nt on a self-signed server.

The MXMediaLoader adds now all the allowed certificates to the chain of trust at the time of preparing the SSL negotiation.

element-hq/element-ios#816
@giomfo
Copy link
Member

giomfo commented Jul 20, 2017

@edam: Fixed on matrix-ios-sdk develop. Thanks again for your help.
The MXMediaLoader adds now all the allowed certificates to the chain of trust at the time of preparing the SSL negotiation.

@giomfo giomfo closed this as completed Jul 20, 2017
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 20, 2017
Avatars do not display with matrix.org account after trusting a self-signed certificate.
Fix: reenable trusting anchor certificates in addition to those passed in via the SecTrustSetAnchorCertificates API.

element-hq/element-ios#816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants