Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot looks to me like I'm sending the same message twice #894

Closed
giomfo opened this issue Dec 27, 2016 · 4 comments
Closed

Riot looks to me like I'm sending the same message twice #894

giomfo opened this issue Dec 27, 2016 · 4 comments
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@giomfo
Copy link
Member

giomfo commented Dec 27, 2016

Reported by several users:

"Riot iOS suddenly started displaying my messages as if I'd sent the same thing twice. Recipients said it looked like one message to them. I switched rooms and it didn't happen when sending a message to another room."
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 labels Dec 27, 2016
@giomfo giomfo self-assigned this Dec 27, 2016
@giomfo
Copy link
Member Author

giomfo commented Jan 17, 2017

Reproduced, fix is in progress

@jeangb
Copy link

jeangb commented Jan 18, 2017

Steps to reproduce:

  1. Open a room with enough bubbles in it to be necessary to scroll up several times to see the first msg
  2. Open room details
  3. Hit the FILES tab
  4. Go back in the room view, scroll up several times to load previous bubbles
  5. Go back in rooms list
  6. From the rooms list, open again the room
  7. Post a message

Msg is duplicated

@jeangb jeangb self-assigned this Jan 18, 2017
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 18, 2017
@giomfo
Bug Fix: Riot looks to me like I'm sending the same message twice.
c2d1197 
element-hq/element-ios#894

Move the local echo suppression from `MXKRoomDataSource` to `MXEventTimeline` class.
@giomfo giomfo mentioned this issue Jan 18, 2017
Merged
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Jan 18, 2017
@giomfo
Bug Fix: Riot looks to me like I'm sending the same message twice.
b524b82 
element-hq/element-ios#894

Move the local echo suppression from `MXKRoomDataSource` to `MXEventTimeline` class.
@giomfo giomfo mentioned this issue Jan 18, 2017
Merged
@giomfo
Copy link
Member Author

giomfo commented Jan 18, 2017

Done, wait for testing

@giomfo giomfo removed their assignment Jan 18, 2017
@jeangb
Copy link

jeangb commented Jan 18, 2017

Validated with 0.3.6 develop #1536

@jeangb jeangb closed this as completed Jan 18, 2017
@jeangb jeangb removed their assignment Jan 18, 2017
@giomfo giomfo mentioned this issue Jan 30, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giomfo @jeangb