MediaPicker xib layout fix #1372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@automactic: First of all, thanks for your contribution. I reviewed your PR, I keep the idea of adding the constraint on the container height. But I did not remove the aspect ratio constraint (I reduced its priority compared to the height constraint). Because I developed/tested these changes on my own branch, and fixed another issue (#686). I created my own PR(#1388) to merge on develop. I will close this one. BTW, if you want to submit other PRs, you should prepare them to commit into vector-im:develop (and not master). And you will have to sign off them (see details in https://github.com/vector-im/riot-ios/blob/master/CONTRIBUTING.rst). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CaptureView in the MediaPickerController has a fixed aspect ratio. This results in not being able to see the CaptureButton without scrolling on iPads. In this pull request, I am trying to fix this issue by removing the CaptureView's aspect ratio constrain and adding CaptureView's height equals MainScrollView's parent view height constrain.
I have not tested this on real device since I cannot build this app on my machine (profiling issue). Please help me test it if anyone could. Thanks!
BTW, awesome app! 馃槉