Use SwiftLint to enforce Swift style and conventions #2300
Conversation
| @@ -71,7 +71,7 @@ PODS: | |||
| - GZIP (~> 1.2.2) | |||
| - libbase58 (~> 0.1.4) | |||
| - OLMKit (~> 3.0.0) | |||
| - Realm (~> 3.13.1) | |||
| - Realm (~> 3.11.1) | |||
There was a problem hiding this comment.
To make pod install working with MatrixKit 0.9.5
There was a problem hiding this comment.
riot-ios/develop should use pods of kit/develop & sdk/develop
There was a problem hiding this comment.
If you uncomment $matrixKitVersion = 'develop' and perform a pod install it will update the podfile.lock correctly and bump Realm to 3.13.1. The podfile.lock here was generated by using default kit version $matrixKitVersion = '0.9.5' in podfile.
There was a problem hiding this comment.
If you uncomment
$matrixKitVersion = 'develop'and perform a pod install it will update the podfile.lock correctly and bump Realm to 3.13.1.
yes. This is what I meant to avoid to do a stupid rm Podfile.lock the day of the release.
| - Riot/Generated/ | ||
|
|
||
| line_length: | ||
| warning: 250 |
There was a problem hiding this comment.
250 seems huge. Error on 160 seems more reasonable.
There was a problem hiding this comment.
Yes it seems huge but several delegate methods and SwiftGen constants are near 200 characters
There was a problem hiding this comment.
several delegate methods
This is another reason I hate them but well :/
No description provided.