Add generic SwiftUI Error type #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopt it in Location Sharing and Polls.
pixlwave
force-pushed
the
doug/swiftui_errors
branch
from
b38c8d3
to
0d04dbe
Compare
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/waijU5 |
pixlwave
force-pushed
the
doug/swiftui_errors
branch
from
0d04dbe
to
87d62b8
Compare
stefanceriu
approved these changes
Mar 4, 2022
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic
ErrorAlertTypestruct that can be used to describe an Alert to be presented. We can pass anNSErrorto the init to use it in a similar way to the existingerrorPresenterin the UIKit templates. Additionally replacesLocationSharingErrorAlertInfoandTimelinePollErrorAlertInfowith this new type.@stefanceriu WDYT about the style of having the
ErrorAlertType.alertproperty where the type creates and returns the view? I'm perfectly happy with this when it's simple, but happy to revert it back to the previous commit where there is only a convenience property for themessageTextif you prefer?Note: I haven't tested the errors for polls/location sharing.