Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets recovery: Fix an issue where the Secrets Reset screen would open twice. #7404

Merged
merged 2 commits into from
May 5, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Mar 3, 2023

This PR fixes the following issues when resetting secrets:

  • SecureBackupSetupIntroViewController is pushed twice into the navigation router (once as a view controller, once via its navigation controller)
  • SecureBackupSetupCoordinator is never removed from child coordinators

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.14 🎉

Comparison is base (cb7f6a7) 12.22% compared to head (0240e35) 12.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7404      +/-   ##
===========================================
+ Coverage    12.22%   12.37%   +0.14%     
===========================================
  Files         1646     1646              
  Lines       163369   163381      +12     
  Branches     67067    67088      +21     
===========================================
+ Hits         19975    20215     +240     
+ Misses      142750   142502     -248     
- Partials       644      664      +20     
Flag Coverage Δ
uitests 55.06% <ø> (ø)
unittests 6.21% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Secrets/Recover/SecretsRecoveryCoordinator.swift 0.00% <0.00%> (ø)
...odules/Secrets/Reset/SecretsResetCoordinator.swift 0.00% <0.00%> (ø)
...les/Secrets/Reset/SecretsResetViewController.swift 0.00% <0.00%> (ø)
.../Modules/Secrets/Reset/SecretsResetViewModel.swift 0.00% <0.00%> (ø)
...ureBackup/Setup/SecureBackupSetupCoordinator.swift 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau force-pushed the nimau/PSB-269-reset-passphrase branch from 82256eb to 2aa1a08 Compare April 3, 2023 11:54
@nimau nimau force-pushed the nimau/PSB-269-reset-passphrase branch from 2aa1a08 to 11587f0 Compare May 2, 2023 14:53
@nimau nimau changed the title Secrets recovery: fix an issue preventing the release of SecureBackupSetupCoordinator Secrets recovery: Fix an issue where the secrets reset screen is pushed twice. May 2, 2023
@nimau nimau force-pushed the nimau/PSB-269-reset-passphrase branch from 11587f0 to 0240e35 Compare May 2, 2023 14:56
@nimau nimau changed the title Secrets recovery: Fix an issue where the secrets reset screen is pushed twice. Secrets recovery: Fix an issue where the Secrets Reset screen would open twice. May 2, 2023
@nimau nimau marked this pull request as ready for review May 2, 2023 14:57
@nimau nimau requested review from a team and aringenbach and removed request for a team May 2, 2023 14:57
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimau nimau merged commit cb1ca0a into develop May 5, 2023
13 checks passed
@nimau nimau deleted the nimau/PSB-269-reset-passphrase branch May 5, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants