Simplify event encryption decoration #7440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/trust_shields
branch
from
14c7ddb
to
c2cb638
Compare
Anderas
requested review from
a team and
pixlwave
and removed request for
a team
pixlwave
approved these changes
Mar 21, 2023
Anderas
force-pushed
the
andy/trust_shields
branch
from
c2cb638
to
2379bb1
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7440 +/- ##
===========================================
- Coverage 12.29% 12.29% -0.01%
===========================================
Files 1645 1645
Lines 162976 162979 +3
Branches 66913 66912 -1
===========================================
Hits 20045 20045
- Misses 142282 142285 +3
Partials 649 649
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Anderas
force-pushed
the
andy/trust_shields
branch
from
2379bb1
to
39fdbc9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related SDK change matrix-org/matrix-ios-sdk#1743
Resolves #7441
Move some of the event encryption decoration logic down into the SDK and simplify the model to only mention colors (red, grey, none) rather than reasons (unsafe key, untrusted ...)