Fix accessibility behavior on "enter PIN" screen #7522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfogrillo
commented
Apr 26, 2023
Comment on lines
+258
to
+260
| <accessibility key="accessibilityConfiguration"> | ||
| <bool key="isElement" value="NO"/> | ||
| </accessibility> |
There was a problem hiding this comment.
This is the only relevant change in the storyboard, all the other changes have been automatically generated by Xcode.
alfogrillo
requested review from
a team and
Velin92
and removed request for
a team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7522 +/- ##
===========================================
+ Coverage 12.21% 12.36% +0.14%
===========================================
Files 1646 1646
Lines 163319 163326 +7
Branches 67038 67056 +18
===========================================
+ Hits 19944 20188 +244
+ Misses 142733 142475 -258
- Partials 642 663 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alfogrillo
force-pushed
the
alfogrillo/fix_accessibility_pin_screen
branch
from
5748ff4
to
fda7183
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of accessibility issue on the "enter PIN" screen:
Affected screen
