Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voiceover order of room creation header and message composer. #7543

Merged
merged 1 commit into from
May 10, 2023

Conversation

pixlwave
Copy link
Contributor

This PR makes 3 changes to voiceover:

  • The room creation cell exposes accessibility elements directly (previously it would read out "Add People" for the whole cell and then navigate inside the cell after.
  • The message composer Editing/Replying header and button are hidden from VoiceOver when not visible.
  • The order of the message composer's accessibility elements is defined manually.

@pixlwave pixlwave requested review from a team and flescio and removed request for a team May 10, 2023 10:46
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (ef4d85d) 12.36% compared to head (f652bf8) 12.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7543      +/-   ##
===========================================
- Coverage    12.36%   12.21%   -0.15%     
===========================================
  Files         1646     1646              
  Lines       163465   163486      +21     
  Branches     67128    67112      -16     
===========================================
- Hits         20213    19973     -240     
- Misses      142589   142870     +281     
+ Partials       663      643      -20     
Flag Coverage Δ
uitests 55.06% <ø> (+<0.01%) ⬆️
unittests 6.05% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ells/RoomCreationIntro/RoomCreationIntroCell.swift 0.00% <0.00%> (ø)
...eationIntro/RoomCreationIntroCellContentView.swift 0.00% <0.00%> (ø)
...les/Room/Views/InputToolbar/RoomInputToolbarView.m 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@flescio flescio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit 0c8c1ce into develop May 10, 2023
13 checks passed
@pixlwave pixlwave deleted the doug/timeline-voiceover branch May 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants