Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline state issue in user sessions overview #7562

Merged
merged 4 commits into from
May 30, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented May 29, 2023

This PR fixes an inconsistency on the device manager main screen when the app is launched without an internet connection.

Previously: the current device session was arbitrarily shown as "unverified"
Now: the current device session is shown as "unknown"

Result
d

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.15 ⚠️

Comparison is base (94d19d4) 12.36% compared to head (21670e4) 12.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7562      +/-   ##
===========================================
- Coverage    12.36%   12.22%   -0.15%     
===========================================
  Files         1648     1648              
  Lines       163581   163590       +9     
  Branches     67170    67156      -14     
===========================================
- Hits         20226    19992     -234     
- Misses      142690   142953     +263     
+ Partials       665      645      -20     
Flag Coverage Δ
uitests 55.05% <ø> (-0.01%) ⬇️
unittests 6.06% <83.33%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...w/Service/MatrixSDK/UserSessionsDataProvider.swift 44.73% <81.81%> (+4.43%) ⬆️
...ervice/MatrixSDK/UserSessionsOverviewService.swift 84.32% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo force-pushed the alfogrillo/dm_no_internet_status branch from 7275a49 to 6a58218 Compare May 29, 2023 13:21
@alfogrillo alfogrillo changed the title Handle offline issue in UserSessionsDataProvider Fix offline state issue in user sessions overview May 29, 2023
@alfogrillo alfogrillo marked this pull request as ready for review May 29, 2023 13:26
@alfogrillo alfogrillo requested review from a team and aringenbach and removed request for a team May 29, 2023 13:26
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfogrillo alfogrillo merged commit 2bd099e into develop May 30, 2023
9 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/dm_no_internet_status branch May 30, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants