Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep links don't give a mobile guide #16283

Closed
turt2live opened this issue Jan 25, 2021 · 7 comments
Closed

Deep links don't give a mobile guide #16283

turt2live opened this issue Jan 25, 2021 · 7 comments
Labels
T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@turt2live
Copy link
Member

see matrix-org/conference-bot#27

@jryans
Copy link
Collaborator

jryans commented Jan 26, 2021

Hmm, I guess I am forgetting some of the history of why we're skipping the mobile guide for deep links and 3PID invites, but it's clearly an intentional choice as part of #7378.

@jryans jryans added T-Enhancement ui/ux X-Needs-Product More input needed from the Product team labels Jan 26, 2021
@benparsons
Copy link
Member

Appears that the decision in 2018 was to show a room preview when the page is loaded on mobile web. Now, the question is whether this preview can also include a mobile guide - a banner which says "if you have the element app installed click to open this room in the app".

Options:

  1. as we are now, a static preview of a room
  2. redirect to mobile app (what happens if the app is not installed? does the browser show an error, or silently fail, sating on the preview page?)
  3. have a CTA banner which suggests those with the app installed click to open the room in the app

@nadonomy
Copy link
Member

@benparsons @jryans I think the rationale in #7378 to show unstyled/non-responsive rooms in the mobile browser is a little short sighted.

Some things that spring to mind for the right solution would be:

  • On iOS, ensure we display a smart app banner with app-argument deep linking
  • On Android, is there an equivalent? I found this on first look but looks to be Chrome only.
  • Improving responsive styling

In an ideal world we'd have all of the above, but @benparsons I know you're looking for something in the immediate term. For your use case, I wonder if we can shortcut this by using matrix.to links instead of deep links to an element web instance? Might be easier to chat in a room so will ping you somewhere sane.

@jryans
Copy link
Collaborator

jryans commented Jan 28, 2021

After chatting with @ara4n today, we're thinking for deep links to rooms generally, matrix.to links with an additional parameter that suggests a specific Element Web deployment (which would need to be added to matrix.to) would be ideal here.

There's a separate problem of 3PID invites. For those, I think it makes sense to complete them in Element Web (which is what already happens), but then have a banner once you're inside (logged in) that nudges you toward the mobile guide.

@jryans
Copy link
Collaborator

jryans commented Jan 28, 2021

@bwindels is going to work on support to suggest specific client instances in matrix.to.

I will work on adding some kind of banner to suggest mobile once you are inside.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 28, 2021
This adds an optional toast which Element deployments can enable to nudge users
towards the mobile apps once they are inside the app.

Part of element-hq/element-web#16283
jryans added a commit that referenced this issue Jan 28, 2021
@jryans
Copy link
Collaborator

jryans commented Jan 29, 2021

The mobile guide toast has merged to develop, and can be enabled with mobileGuideToast: true in config.json.

@jryans
Copy link
Collaborator

jryans commented Feb 3, 2021

I believe the matrix.to side of this has been resolved by @bwindels, so I believe we're all done here.

@jryans jryans closed this as completed Feb 3, 2021
@jryans jryans removed the Z-UI/UX label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

4 participants