Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[request] Make room mention pill, when its a space, be more square-ish than round-ish #17248

Closed
ShadowJonathan opened this issue May 11, 2021 · 1 comment
Closed

[request] Make room mention pill, when its a space, be more square-ish than round-ish #17248

ShadowJonathan opened this issue May 11, 2021 · 1 comment
Assignees
@SimonBrandner
Labels
A-Pills A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented May 11, 2021 •
edited
Loading

Related to #17244

I think adding that little touch of design language helps solidify the differences between spaces and rooms as simple as "circle" and "square"
@SimonBrandner SimonBrandner added A-Pills A-Spaces Spaces, groups, communities labels May 11, 2021
@SimonBrandner SimonBrandner mentioned this issue Jul 18, 2021
Merged
@SimonBrandner SimonBrandner self-assigned this Jul 18, 2021
@t3chguy t3chguy added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 14, 2022
@gaelledel
Copy link

It is better practice to keep small components like these consistent no matter the context as its core functionality is to do the same action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Pills A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@t3chguy @ShadowJonathan @SimonBrandner @gaelledel