Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotifPanel layout regressions #17580

Closed
ara4n opened this issue Jun 7, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6157
Closed

NotifPanel layout regressions #17580

ara4n opened this issue Jun 7, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6157
Assignees
@jryans
Labels
A-Notif-Panel P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Jun 7, 2021 •
edited

Screenshot 2021-06-07 at 12 03 55
@ara4n
Copy link
Member Author

ara4n commented Jun 7, 2021

n.b. lack of whitespace between Thib & timestamp (and presumably timestamp being in the wrong place entirely)

@jryans jryans added A-Notif-Panel P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Release-Blocker labels Jun 7, 2021
@jryans
Copy link
Collaborator

jryans commented Jun 7, 2021

This appears to affect the RC on staging as well, so ideally we'll find a fix today and send it to the release branch as well.

@jryans
Copy link
Collaborator

jryans commented Jun 7, 2021 •
edited

Hmm, seems to be related to some part of matrix-org/matrix-react-sdk@d362321 / matrix-org/matrix-react-sdk#6079.

@jryans jryans self-assigned this Jun 7, 2021
@jryans jryans added this to In Progress in Web App Team Jun 7, 2021
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 7, 2021
@jryans
Fix notif panel timestamp padding
a895b08 
This restores some space around the timestamp in the notif panel. We were
previously relying somewhat randomly on the presence on empty flair elements to
create space.

Fixes element-hq/element-web#17580
@jryans jryans mentioned this issue Jun 7, 2021
Merged
Web App Team automation moved this from In Progress to In Test Jun 7, 2021
@jryans
Copy link
Collaborator

jryans commented Jun 7, 2021

Hmm, seems to be related to some part of matrix-org/matrix-react-sdk@d362321 / matrix-org/matrix-react-sdk#6079.

Actually, these are only on develop so far, so not entirely sure which was the regressing change at the moment. Anyway, I'll send the fix also to release.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 7, 2021
@jryans
Fix notif panel timestamp padding
296186b 
This restores some space around the timestamp in the notif panel. We were
previously relying somewhat randomly on the presence on empty flair elements to
create space.

Fixes element-hq/element-web#17580
@jryans jryans moved this from In Test to In RC in Web App Team Jun 7, 2021
@germain-gg germain-gg mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Notif-Panel P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix notif panel timestamp padding matrix-org/matrix-react-sdk
3 participants
@jryans @ara4n @t3chguy