Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging PiP from the avatar goes back to room on drop #18421

Closed
afranke opened this issue Aug 6, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#7142
Closed

Dragging PiP from the avatar goes back to room on drop #18421

afranke opened this issue Aug 6, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#7142
Assignees
@SimonBrandner
Labels
A-Picture-in-Picture A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@afranke
Copy link
Contributor

afranke commented Aug 6, 2021

Steps to reproduce

  • Start a video call in your 1-1 room with Alice
  • Switch to any other room from the sidebar. Video call is overlaid (PiP) in one of the corners.
  • Move your mouse over Alice’s avatar in the header of the PiP.
  • Click and start dragging the PiP.
  • Wait for it to catch up to your mouse position. Drop the PiP (release mouse button).

Expected: the PiP behaves like it would if I had dragged from any other draggable part of it
Actual result: Element switches to Alice’s room, as if I had clicked on the avatar or the top right icon.

Version information

  • Platform: web
  • Browser: Firefox 90.0.2
  • OS: Fedora 34
  • URL: develop.element.io
@SimonBrandner SimonBrandner added A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 6, 2021
@SimonBrandner
Copy link
Contributor

Related: #15920

@SimonBrandner
Copy link
Contributor

@gaelledel, do you have any thoughts on how clicking/dragging different parts of the PiP should behave? Also, in connection with #15920

@germain-gg
Copy link
Contributor

germain-gg commented Aug 6, 2021 •
edited

I have not been able to reproduce following the provided steps

Could you try again and maybe share a little film-strip of the problem you're experiencing?

@SimonBrandner
Copy link
Contributor

I can repro on FF:

Peek.2021-08-06.12-47.mp4

@jryans
Copy link
Collaborator

jryans commented Nov 4, 2021

I don't think this one needs Design, seems fairly straight forward to me.

@toger5 toger5 self-assigned this Nov 4, 2021
@SimonBrandner SimonBrandner mentioned this issue Nov 15, 2021
Merged
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Nov 22, 2021
@BBaoVanC
Merge tag 'v1.9.5' into build
a0596e6 
* Make double-clicking the PiP take you to the call room ([\element-hq#7142](matrix-org/matrix-react-sdk#7142)). Fixes element-hq#18421 element-hq#15920 and element-hq#18421. Contributed by @SimonBrandner.
* Add maximise widget functionality ([\element-hq#7098](matrix-org/matrix-react-sdk#7098)). Fixes element-hq#19619, element-hq#19621 element-hq#19760 and element-hq#19619.
* Add rainfall effect ([\element-hq#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias.
* Add root folder to zip file created by export chat feature ([\element-hq#7097](matrix-org/matrix-react-sdk#7097)). Fixes element-hq#19653 and element-hq#19653. Contributed by @aaronraimist.
* Improve VoIP UI/UX ([\element-hq#7048](matrix-org/matrix-react-sdk#7048)). Fixes element-hq#19513 and element-hq#19513. Contributed by @SimonBrandner.
* Unified room context menus ([\element-hq#7072](matrix-org/matrix-react-sdk#7072)). Fixes element-hq#19527 and element-hq#19527.
* In forgot password screen, show validation errors inline in the form, instead of in modals ([\element-hq#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto.
* Implement more meta-spaces ([\element-hq#7077](matrix-org/matrix-react-sdk#7077)). Fixes element-hq#18634 element-hq#17295 and element-hq#18634.
* Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)).
* Forget member-list query when switching out of a room ([\element-hq#7093](matrix-org/matrix-react-sdk#7093)). Fixes element-hq#19432 and element-hq#19432. Contributed by @SimonBrandner.
* Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes element-hq#9545 and element-hq#9545.
* Adjust recovery key button sizes depending on text width ([\element-hq#7134](matrix-org/matrix-react-sdk#7134)). Fixes element-hq#19511 and element-hq#19511. Contributed by @weeman1337.
* Fix bulk invite button getting a negative count ([\element-hq#7122](matrix-org/matrix-react-sdk#7122)). Fixes element-hq#19466 and element-hq#19466. Contributed by @renancleyson-dev.
* Fix maximised / pinned widget state being loaded correctly ([\element-hq#7146](matrix-org/matrix-react-sdk#7146)). Fixes element-hq#19768 and element-hq#19768.
* Don't reload the page when user hits enter when entering ban reason ([\element-hq#7145](matrix-org/matrix-react-sdk#7145)). Fixes element-hq#19763 and element-hq#19763.
* Fix timeline text when sharing room layout ([\element-hq#7140](matrix-org/matrix-react-sdk#7140)). Fixes element-hq#19622 and element-hq#19622.
* Fix look of emoji verification ([\element-hq#7133](matrix-org/matrix-react-sdk#7133)). Fixes element-hq#19740 and element-hq#19740. Contributed by @SimonBrandner.
* Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes element-hq#16672, matrix-org/element-web-rageshakes#4407, element-hq#15718 element-hq#15768 and element-hq#16672.
* Don't keep spinning if joining space child failed ([\element-hq#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813.
* Guard around SpaceStore onAccountData handler prevEvent ([\element-hq#7123](matrix-org/matrix-react-sdk#7123)). Fixes element-hq#19705 and element-hq#19705.
* Fix missing spaces in threads copy ([\element-hq#7119](matrix-org/matrix-react-sdk#7119)). Fixes element-hq#19702 and element-hq#19702.
* Fix hover tile border ([\element-hq#7117](matrix-org/matrix-react-sdk#7117)). Fixes element-hq#19698 and element-hq#19698. Contributed by @SimonBrandner.
* Fix quote button ([\element-hq#7096](matrix-org/matrix-react-sdk#7096)). Fixes element-hq#19659 and element-hq#19659. Contributed by @SimonBrandner.
* Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes element-hq#19668 and element-hq#19668.
* Update powerlevel/role when the user changes in the user info panel ([\element-hq#7099](matrix-org/matrix-react-sdk#7099)). Fixes element-hq#19666 and element-hq#19666. Contributed by @SimonBrandner.
* Fix avatar disappearing when setting a room topic ([\element-hq#7092](matrix-org/matrix-react-sdk#7092)). Fixes element-hq#19226 and element-hq#19226. Contributed by @SimonBrandner.
* Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes element-hq#15494 and element-hq#15494.
* Use device IDs for nameless devices in device list ([\element-hq#7081](matrix-org/matrix-react-sdk#7081)). Fixes element-hq#19608 and element-hq#19608.
* Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\element-hq#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray.
su-ex added a commit to SchildiChat/element-web that referenced this issue Nov 24, 2021
@su-ex
Merge tag 'v1.9.5' into sc
7355e03 
* Make double-clicking the PiP take you to the call room ([\element-hq#7142](matrix-org/matrix-react-sdk#7142)). Fixes element-hq#18421 element-hq#15920 and element-hq#18421. Contributed by @SimonBrandner.
* Add maximise widget functionality ([\element-hq#7098](matrix-org/matrix-react-sdk#7098)). Fixes element-hq#19619, element-hq#19621 element-hq#19760 and element-hq#19619.
* Add rainfall effect ([\element-hq#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias.
* Add root folder to zip file created by export chat feature ([\element-hq#7097](matrix-org/matrix-react-sdk#7097)). Fixes element-hq#19653 and element-hq#19653. Contributed by @aaronraimist.
* Improve VoIP UI/UX ([\element-hq#7048](matrix-org/matrix-react-sdk#7048)). Fixes element-hq#19513 and element-hq#19513. Contributed by @SimonBrandner.
* Unified room context menus ([\element-hq#7072](matrix-org/matrix-react-sdk#7072)). Fixes element-hq#19527 and element-hq#19527.
* In forgot password screen, show validation errors inline in the form, instead of in modals ([\element-hq#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto.
* Implement more meta-spaces ([\element-hq#7077](matrix-org/matrix-react-sdk#7077)). Fixes element-hq#18634 element-hq#17295 and element-hq#18634.
* Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)).
* Forget member-list query when switching out of a room ([\element-hq#7093](matrix-org/matrix-react-sdk#7093)). Fixes element-hq#19432 and element-hq#19432. Contributed by @SimonBrandner.
* Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes element-hq#9545 and element-hq#9545.
* Adjust recovery key button sizes depending on text width ([\element-hq#7134](matrix-org/matrix-react-sdk#7134)). Fixes element-hq#19511 and element-hq#19511. Contributed by @weeman1337.
* Fix bulk invite button getting a negative count ([\element-hq#7122](matrix-org/matrix-react-sdk#7122)). Fixes element-hq#19466 and element-hq#19466. Contributed by @renancleyson-dev.
* Fix maximised / pinned widget state being loaded correctly ([\element-hq#7146](matrix-org/matrix-react-sdk#7146)). Fixes element-hq#19768 and element-hq#19768.
* Don't reload the page when user hits enter when entering ban reason ([\element-hq#7145](matrix-org/matrix-react-sdk#7145)). Fixes element-hq#19763 and element-hq#19763.
* Fix timeline text when sharing room layout ([\element-hq#7140](matrix-org/matrix-react-sdk#7140)). Fixes element-hq#19622 and element-hq#19622.
* Fix look of emoji verification ([\element-hq#7133](matrix-org/matrix-react-sdk#7133)). Fixes element-hq#19740 and element-hq#19740. Contributed by @SimonBrandner.
* Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes element-hq#16672, matrix-org/element-web-rageshakes#4407, element-hq#15718 element-hq#15768 and element-hq#16672.
* Don't keep spinning if joining space child failed ([\element-hq#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813.
* Guard around SpaceStore onAccountData handler prevEvent ([\element-hq#7123](matrix-org/matrix-react-sdk#7123)). Fixes element-hq#19705 and element-hq#19705.
* Fix missing spaces in threads copy ([\element-hq#7119](matrix-org/matrix-react-sdk#7119)). Fixes element-hq#19702 and element-hq#19702.
* Fix hover tile border ([\element-hq#7117](matrix-org/matrix-react-sdk#7117)). Fixes element-hq#19698 and element-hq#19698. Contributed by @SimonBrandner.
* Fix quote button ([\element-hq#7096](matrix-org/matrix-react-sdk#7096)). Fixes element-hq#19659 and element-hq#19659. Contributed by @SimonBrandner.
* Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes element-hq#19668 and element-hq#19668.
* Update powerlevel/role when the user changes in the user info panel ([\element-hq#7099](matrix-org/matrix-react-sdk#7099)). Fixes element-hq#19666 and element-hq#19666. Contributed by @SimonBrandner.
* Fix avatar disappearing when setting a room topic ([\element-hq#7092](matrix-org/matrix-react-sdk#7092)). Fixes element-hq#19226 and element-hq#19226. Contributed by @SimonBrandner.
* Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes element-hq#15494 and element-hq#15494.
* Use device IDs for nameless devices in device list ([\element-hq#7081](matrix-org/matrix-react-sdk#7081)). Fixes element-hq#19608 and element-hq#19608.
* Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\element-hq#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray.
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Nov 24, 2021
@su-ex
Merge tag 'v1.9.5' into sc
d573aae 
* Make double-clicking the PiP take you to the call room ([\#7142](matrix-org/matrix-react-sdk#7142)). Fixes element-hq/element-web#18421 element-hq/element-web#15920 and element-hq/element-web#18421. Contributed by @SimonBrandner.
* Add maximise widget functionality ([\#7098](matrix-org/matrix-react-sdk#7098)). Fixes element-hq/element-web#19619, element-hq/element-web#19621 element-hq/element-web#19760 and element-hq/element-web#19619.
* Add rainfall effect ([\#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias.
* Add root folder to zip file created by export chat feature ([\#7097](matrix-org/matrix-react-sdk#7097)). Fixes element-hq/element-web#19653 and element-hq/element-web#19653. Contributed by @aaronraimist.
* Improve VoIP UI/UX ([\#7048](matrix-org/matrix-react-sdk#7048)). Fixes element-hq/element-web#19513 and element-hq/element-web#19513. Contributed by @SimonBrandner.
* Unified room context menus ([\#7072](matrix-org/matrix-react-sdk#7072)). Fixes element-hq/element-web#19527 and element-hq/element-web#19527.
* In forgot password screen, show validation errors inline in the form, instead of in modals ([\#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto.
* Implement more meta-spaces ([\#7077](matrix-org/matrix-react-sdk#7077)). Fixes element-hq/element-web#18634 element-hq/element-web#17295 and element-hq/element-web#18634.
* Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)).
* Forget member-list query when switching out of a room ([\#7093](matrix-org/matrix-react-sdk#7093)). Fixes element-hq/element-web#19432 and element-hq/element-web#19432. Contributed by @SimonBrandner.
* Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes element-hq/element-web#9545 and element-hq/element-web#9545.
* Adjust recovery key button sizes depending on text width ([\#7134](matrix-org/matrix-react-sdk#7134)). Fixes element-hq/element-web#19511 and element-hq/element-web#19511. Contributed by @weeman1337.
* Fix bulk invite button getting a negative count ([\#7122](matrix-org/matrix-react-sdk#7122)). Fixes element-hq/element-web#19466 and element-hq/element-web#19466. Contributed by @renancleyson-dev.
* Fix maximised / pinned widget state being loaded correctly ([\#7146](matrix-org/matrix-react-sdk#7146)). Fixes element-hq/element-web#19768 and element-hq/element-web#19768.
* Don't reload the page when user hits enter when entering ban reason ([\#7145](matrix-org/matrix-react-sdk#7145)). Fixes element-hq/element-web#19763 and element-hq/element-web#19763.
* Fix timeline text when sharing room layout ([\#7140](matrix-org/matrix-react-sdk#7140)). Fixes element-hq/element-web#19622 and element-hq/element-web#19622.
* Fix look of emoji verification ([\#7133](matrix-org/matrix-react-sdk#7133)). Fixes element-hq/element-web#19740 and element-hq/element-web#19740. Contributed by @SimonBrandner.
* Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes element-hq/element-web#16672, matrix-org/element-web-rageshakes#4407, element-hq/element-web#15718 element-hq/element-web#15768 and element-hq/element-web#16672.
* Don't keep spinning if joining space child failed ([\#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813.
* Guard around SpaceStore onAccountData handler prevEvent ([\#7123](matrix-org/matrix-react-sdk#7123)). Fixes element-hq/element-web#19705 and element-hq/element-web#19705.
* Fix missing spaces in threads copy ([\#7119](matrix-org/matrix-react-sdk#7119)). Fixes element-hq/element-web#19702 and element-hq/element-web#19702.
* Fix hover tile border ([\#7117](matrix-org/matrix-react-sdk#7117)). Fixes element-hq/element-web#19698 and element-hq/element-web#19698. Contributed by @SimonBrandner.
* Fix quote button ([\#7096](matrix-org/matrix-react-sdk#7096)). Fixes element-hq/element-web#19659 and element-hq/element-web#19659. Contributed by @SimonBrandner.
* Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes element-hq/element-web#19668 and element-hq/element-web#19668.
* Update powerlevel/role when the user changes in the user info panel ([\#7099](matrix-org/matrix-react-sdk#7099)). Fixes element-hq/element-web#19666 and element-hq/element-web#19666. Contributed by @SimonBrandner.
* Fix avatar disappearing when setting a room topic ([\#7092](matrix-org/matrix-react-sdk#7092)). Fixes element-hq/element-web#19226 and element-hq/element-web#19226. Contributed by @SimonBrandner.
* Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes element-hq/element-web#15494 and element-hq/element-web#15494.
* Use device IDs for nameless devices in device list ([\#7081](matrix-org/matrix-react-sdk#7081)). Fixes element-hq/element-web#19608 and element-hq/element-web#19608.
* Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Picture-in-Picture A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make double-clicking the PiP take you to the call room SimonBrandner/matrix-react-sdk
5 participants
@afranke @jryans @germain-gg @toger5 @SimonBrandner