Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes of edited enencrypted messages cannot be shown #19651

Closed
waclaw66 opened this issue Nov 7, 2021 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2013
Closed

Changes of edited enencrypted messages cannot be shown #19651

waclaw66 opened this issue Nov 7, 2021 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2013
Labels
A-E2EE A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@waclaw66
Copy link
Contributor

waclaw66 commented Nov 7, 2021 •
edited

Steps to reproduce

  1. Send an unencrypted message to encrypted room (e.g. via curl)
  2. Edit that message (e.g. in Element Web)
  3. Click to (edited) to show edits

Outcome

What did you expect?

List of changes. That works well for encrypted messages. It works properly on Element Android even for unencrypted messages.

What happened instead?

obrazek

Operating system

Windows 10

Browser information

Firefox 95b3

URL for webapp

own

Application version

Element version: 1.9.4-rc.1 Olm version: 3.2.3

Homeserver

own

Will you send logs?

Yes
@aaronraimist
Copy link
Collaborator

You say redact but I think you mean edit.

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 8, 2021
@waclaw66
Copy link
Contributor Author

waclaw66 commented Nov 8, 2021 •
edited

You're right, redaction means removal in Matrix terminology.

You say redact but I think you mean edit.

@waclaw66 waclaw66 changed the title Changes of redacted enencrypted message cannot be shown Changes of edited enencrypted messages cannot be shown Nov 8, 2021
@aaronraimist aaronraimist added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 8, 2021
@aaronraimist aaronraimist mentioned this issue Nov 8, 2021
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Nov 24, 2021
@su-ex
Merge tag 'v15.1.1' into sc
b3aa5e5 
* Fix edit history being broken after editing an unencrypted event with an encrypted event ([\matrix-org#2013](matrix-org#2013)). Fixes element-hq/element-web#19651 and element-hq/element-web#19651. Contributed by @aaronraimist.
* Make events pagination responses parse threads ([\matrix-org#2011](matrix-org#2011)). Fixes element-hq/element-web#19587 and element-hq/element-web#19587.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
3 participants
@aaronraimist @waclaw66 @SimonBrandner