Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening room list category locks the UI #20884

Closed
germain-gg opened this issue Feb 3, 2022 · 2 comments
Closed

Opening room list category locks the UI #20884

germain-gg opened this issue Feb 3, 2022 · 2 comments
Labels
A-Performance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-t3chguy

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Feb 3, 2022 •
edited
Loading

Steps to reproduce

  1. Opening a collapsed tag in the room list

Outcome

What did you expect?

For this to feel seemless

What happened instead?

Some folks, especially on Web (Electron seems to be less severely affected) experience very low refresh rate

Debugging info

Screen Shot 2022-02-03 at 09 00 54

Screen Shot 2022-02-03 at 09 01 48

It can trace that back to Tooltip.tsx#updatePosition that seems to trigger a relayout way more often that it should
Can share the Chrome performance recording privately

Operating system

all

Browser information

Chrome

URL for webapp

develop.element.io

Application version

Element Nightly version: 2022020201

Homeserver

No response

Will you send logs?

No
@germain-gg germain-gg added T-Defect A-Performance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 3, 2022
@germain-gg germain-gg changed the title UI is feeling sluggish Opening room list category locks the UI Feb 3, 2022
@germain-gg germain-gg mentioned this issue Feb 3, 2022
Closed
@germain-gg germain-gg mentioned this issue Mar 2, 2022
Merged
@MadLittleMods
Copy link
Contributor

@gsouquet How is this feeling for you now that matrix-org/matrix-react-sdk#7939 is merged (on develop)? That PR optimizes the Tooltips which were causing the updatePosition calls in the performance profile from the issue description here.

@robintown
Copy link
Member

Assuming that the above PR has indeed fixed this due to lack of response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Performance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-t3chguy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@novocaine @MadLittleMods @germain-gg @t3chguy @robintown