Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads panel immediately re-opens #23764

Closed
andybalaam opened this issue Nov 14, 2022 · 8 comments · Fixed by matrix-org/matrix-react-sdk#9937
Closed

Threads panel immediately re-opens #23764

andybalaam opened this issue Nov 14, 2022 · 8 comments · Fixed by matrix-org/matrix-react-sdk#9937
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@andybalaam
Copy link
Contributor

Steps to reproduce

  1. In a room with several threads, with the thread panel open
  2. Click the X in the top right of the thread panel

Outcome

What did you expect?

The thread panel should disappear.

What happened instead?

The thread panel disappears and then immediately re-appears:

reappearing-thread mp4

[Note: I have tried with both with and without Rich Text Editor enabled in labs.]

Operating system

Ubuntu 22.04

Browser information

Firefox 106.0.2

URL for webapp

https://develop.element.io

Application version

Element version: 8f8a9e1-react-18c03daa865d-js-ba6a001d677f Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes

@andybalaam
Copy link
Contributor Author

When I switch to another room and back, the behaviour stops, and the thread panel can be dismissed successfully.

@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Nov 14, 2022
@daniellekirkwood
Copy link
Contributor

Occasional and Minor make this a P3 for us, but we'll look into it and see if it can be reproduced etc.

👀 @gsouquet

@germain-gg
Copy link
Contributor

Me and @andybalaam did investigate this a bit more together this morning as he could reproduce it!

All the RightPanelStore code seems to be doing what it needs to do. However, Andy managed to get in a state where https://github.com/matrix-org/matrix-react-sdk/blob/6c556cb88c73902f6345fddc24c3f6d2834d1680/src/components/structures/RoomView.tsx#L621 is executed when closed...

We lost track of the problem after that

@robintown
Copy link
Member

For me, what triggers this is opening a thread from a desktop notification.

@andybalaam
Copy link
Contributor Author

Yes, not every time I get a notification, but it does seem like this is caused by desktop notifications

@andybalaam
Copy link
Contributor Author

I am getting this again today, again triggered by clicking a desktop notification.

@andybalaam
Copy link
Contributor Author

This is happening again for me this morning :-(

I'll rageshake.

@andybalaam andybalaam reopened this Jan 24, 2023
@justjanne justjanne self-assigned this Feb 1, 2023
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Feb 1, 2023
* Quotes for rte ([\matrix-org#9932](matrix-org#9932)). Contributed by @alunturner.
* Show the room name in the room header during calls ([\matrix-org#9942](matrix-org#9942)). Fixes element-hq/element-web#24268.
* Add code blocks to rich text editor ([\matrix-org#9921](matrix-org#9921)). Contributed by @alunturner.
* Add new style for inline code ([\matrix-org#9936](matrix-org#9936)). Contributed by @florianduros.
* Add disabled button state to rich text editor ([\matrix-org#9930](matrix-org#9930)). Contributed by @alunturner.
* Change the rageshake "app" for auto-rageshakes ([\matrix-org#9909](matrix-org#9909)).
* Device manager - tweak settings display ([\matrix-org#9905](matrix-org#9905)). Contributed by @kerryarchibald.
* Add list functionality to rich text editor ([\matrix-org#9871](matrix-org#9871)). Contributed by @alunturner.
* Fix RTE focus behaviour in threads ([\matrix-org#9969](matrix-org#9969)). Fixes element-hq/element-web#23755. Contributed by @florianduros.
* #22204 Issue: Centered File info in lightbox ([\matrix-org#9971](matrix-org#9971)). Fixes element-hq/element-web#22204. Contributed by @Spartan09.
* Fix seekbar position for zero length audio ([\matrix-org#9949](matrix-org#9949)). Fixes element-hq/element-web#24248.
* Allow thread panel to be closed after being opened from notification ([\matrix-org#9937](matrix-org#9937)). Fixes element-hq/element-web#23764 element-hq/element-web#23852 and element-hq/element-web#24213. Contributed by @justjanne.
* Only highlight focused menu item if focus is supposed to be visible ([\matrix-org#9945](matrix-org#9945)). Fixes element-hq/element-web#23582.
* Prevent call durations from breaking onto multiple lines ([\matrix-org#9944](matrix-org#9944)).
* Tweak call lobby buttons to more closely match designs ([\matrix-org#9943](matrix-org#9943)).
* Do not show a broadcast as live immediately after the recording has stopped ([\matrix-org#9947](matrix-org#9947)). Fixes element-hq/element-web#24233.
* Clear the RTE before sending a message ([\matrix-org#9948](matrix-org#9948)). Contributed by @florianduros.
* Fix {enter} press in RTE ([\matrix-org#9927](matrix-org#9927)). Contributed by @florianduros.
* Fix the problem that the password reset email has to be confirmed twice ([\matrix-org#9926](matrix-org#9926)). Fixes element-hq/element-web#24226.
* replace .at() with array.length-1 ([\matrix-org#9933](matrix-org#9933)). Fixes matrix-org/element-web-rageshakes#19281.
* Fix broken threads list timestamp layout ([\matrix-org#9922](matrix-org#9922)). Fixes element-hq/element-web#24243 and element-hq/element-web#24191. Contributed by @justjanne.
* Disable multiple messages when {enter} is pressed multiple times ([\matrix-org#9929](matrix-org#9929)). Fixes element-hq/element-web#24249. Contributed by @florianduros.
* Fix logout devices when resetting the password ([\matrix-org#9925](matrix-org#9925)). Fixes element-hq/element-web#24228.
* Fix: Poll replies overflow when not enough space ([\matrix-org#9924](matrix-org#9924)). Fixes element-hq/element-web#24227. Contributed by @kerryarchibald.
* State event updates are not forwarded to the widget from invitation room ([\matrix-org#9802](matrix-org#9802)). Contributed by @maheichyk.
* Fix error when viewing source of redacted events ([\matrix-org#9914](matrix-org#9914)). Fixes element-hq/element-web#24165. Contributed by @clarkf.
* Replace outdated css attribute ([\matrix-org#9912](matrix-org#9912)). Fixes element-hq/element-web#24218. Contributed by @justjanne.
* Clear isLogin theme override when user is no longer viewing login screens ([\matrix-org#9911](matrix-org#9911)). Fixes element-hq/element-web#23893.
* Fix reply action in message context menu notif & file panels ([\matrix-org#9895](matrix-org#9895)). Fixes element-hq/element-web#23970.
* Fix issue where thread dropdown would not show up correctly ([\matrix-org#9872](matrix-org#9872)). Fixes element-hq/element-web#24040. Contributed by @justjanne.
* Fix unexpected composer growing ([\matrix-org#9889](matrix-org#9889)). Contributed by @florianduros.
* Fix misaligned timestamps for thread roots which are emotes ([\matrix-org#9875](matrix-org#9875)). Fixes element-hq/element-web#23897. Contributed by @justjanne.
@justjanne justjanne self-assigned this Feb 10, 2023
@andybalaam
Copy link
Contributor Author

I haven't seen this for a while, so I think it's done.

@justjanne justjanne removed their assignment Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants