Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "null" in mobile_builds should not default to element app #26309

Closed
estellecomment opened this issue Oct 5, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11741
Assignees
Labels
A-New-Users O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@estellecomment
Copy link

Steps to reproduce

  1. Where are you starting? What can you see?
    Configure "mobile_builds" as indicated in config.md, to have no fdroid app.
    "mobile_builds": {
        "ios": "my ios url",
        "android": "my android url",
        "fdroid": null
    },

The documentation says :
"When explicitly null, the app will assume the iOS app cannot be downloaded. When not provided, the default Element app will be assumed available."

  1. What do you click?
    Create a new account. Log in. On first connection, you get UserOnboardingTasks in the main panel.
    Click "Download apps" to get AppDownloadDialog.

Outcome

What did you expect?

No link for fdroid app, as indicated in config.md

What happened instead?

Link to fdroid app for element's android app.

Screen Shot 2023-10-05 at 10 59 01 AM

the code in matrix-react-sdk

It defaults to element apps : https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/dialogs/AppDownloadDialog.tsx#L46

Operating system

macos

Browser information

firefox 117.0.1 (64 bits)

URL for webapp

local build

Application version

element 1.11.40 (but code is still the same in latest develop)

Homeserver

No response

Will you send logs?

No

@t3chguy t3chguy self-assigned this Oct 12, 2023
@robintown robintown added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-New-Users labels Oct 13, 2023
@estellecomment
Copy link
Author

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-New-Users O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants