Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rageshakes include message content #26376

Closed
richvdh opened this issue Oct 16, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11755
Closed

Rageshakes include message content #26376

richvdh opened this issue Oct 16, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11755
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default

Comments

@richvdh
Copy link
Member

richvdh commented Oct 16, 2023

In https://github.com/matrix-org/element-web-rageshakes/issues/22955:

@https://pr10080--matrix-react-sdk.netlify.app/bundles/77f3193d21fa357c3247/bundle.js:309:10
 {"decrypted":{"type":"m.room.message","content":{"msgtype":"m.text","body":"It's strange somtimes my rageshakes aren't visible on https://github.com/matrix-org/element-web-rageshakes/issues\nBut the UX says it was sent. It's the second time i see that, I have to send twice","m.mentions":

In react SDK:

    private verifyEvent(): void {
        this.doVerifyEvent().catch((e) => {
            const event = this.props.mxEvent;
            logger.error("Error getting encryption info on event", e, event);
        });
    }

Introduced in matrix-org/matrix-react-sdk#11589

This primarily effects Element-R, because that ER is more likely to throw an exception here

@richvdh richvdh added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Element-R-Blocker A blocker for enabling Element R by default labels Oct 16, 2023
@germain-gg germain-gg added the A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Feedback-Reporting Reporting process for bugs, debug logs (rageshakes), suggestions O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants