Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we process to-device messages before generating new one-time-keys #2782

Closed
richvdh opened this issue Dec 21, 2016 · 2 comments · Fixed by matrix-org/matrix-js-sdk#370
Closed

Make sure we process to-device messages before generating new one-time-keys #2782

richvdh opened this issue Dec 21, 2016 · 2 comments · Fixed by matrix-org/matrix-js-sdk#370
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround

Comments

@richvdh
Copy link
Member

richvdh commented Dec 21, 2016 •
edited
Loading

On initial sync (or resume after being offline for a while), we might have pending pre-key Olm messages; we should process them before generating any new one-time keys in case we throw away the private one-time-keys
@richvdh richvdh mentioned this issue Dec 21, 2016
Open
@richvdh richvdh added the A-E2EE label Dec 21, 2016
@richvdh richvdh added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 3, 2017
@richvdh
Copy link
Member Author

richvdh commented Jan 3, 2017

can cause uisid; prioritising accordingly

@richvdh richvdh mentioned this issue Jan 19, 2017
Closed
25 tasks
This was referenced Feb 16, 2017
Merged
Merged
@richvdh richvdh closed this as completed Feb 21, 2017
@richvdh richvdh mentioned this issue Mar 15, 2024
Open
@richvdh
Copy link
Member Author

richvdh commented Jun 20, 2017

Fixed in riot-web by matrix-org/matrix-js-sdk#376.
Fixed in riot-ios by matrix-org/matrix-ios-sdk#260
Fixed in riot-android by matrix-org/matrix-android-sdk#142

bwindels added a commit to element-hq/hydrogen-web that referenced this issue Sep 21, 2020
@bwindels
stay in catchup mode as long as there are device messages
c9ee5a5 
this implements element-hq/element-web#2782

it also implements 0 timeout for catchup, getting rid of the
catching up with your convo banner for 30s upon reconnection.
@bwindels bwindels mentioned this issue Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Poll /sync with a short timeout while catching up matrix-org/matrix-js-sdk
1 participant
@richvdh