Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure auth footer links through Riot config #9297

Merged
merged 1 commit into from Mar 28, 2019

Conversation

TheJJ
Copy link
Contributor

@TheJJ TheJJ commented Mar 27, 2019

Our organization needs a imprint and privacy statement right on the login page, and some links to organization pages as well.

I've added a possibility to customize those links through the config.json:

    "branding": {
        # this is already upstream:
        "welcomeBackgroundUrl": "themes/org/bg.jpg",
        "authHeaderLogoUrl": "themes/org/orglogo.svg",

        # these are now added by this pull request:
        "authFooterLinks": [
            {"text": "Our Organization", "url": "https://best-org-ever.edu"},
            {"text": "Some subdepartment", "url": "https://subdepartment.best-org-ever.edu"},
            {"text": "Impressum", "url": "/legal/impressum.html"},
            {"text": "Datenschutz", "url": "/legal/datenschutz.html"},
            {"text": "github", "url": "https://github.com/vector-im/riot-web"}
        ]
    },

Fixes #9127.

@TheJJ TheJJ force-pushed the custom_login_footer_links branch 2 times, most recently from 014af75 to 605ca7f Compare March 27, 2019 13:45
@jryans jryans self-requested a review March 28, 2019 10:16
@jryans jryans changed the title configure auth footer links through sdkconfig Configure auth footer links through Riot config Mar 28, 2019
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It looks reasonable overall, and it addresses something already requested by others. 😁

Please add a line to the config.json section of the README about this new option.

src/components/views/auth/VectorAuthFooter.js Outdated Show resolved Hide resolved
Signed-off-by: Jonas Jelten <jelten@in.tum.de>
@TheJJ TheJJ force-pushed the custom_login_footer_links branch from 605ca7f to 5a05182 Compare March 28, 2019 11:32
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good to me. 😁

@jryans jryans merged commit 01794ae into element-hq:develop Mar 28, 2019
@TheJJ TheJJ deleted the custom_login_footer_links branch March 28, 2019 16:19
@FilexCZE
Copy link

FilexCZE commented Apr 2, 2023

Hey, still this working?

@t3chguy
Copy link
Member

t3chguy commented Apr 3, 2023

@matyasvane yup.

image
https://chat.mozilla.org/#/welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth footer links should be configurable
4 participants