Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen turns off during video playback if there's no user input #1519

Closed
rom4nik opened this issue Oct 9, 2023 · 0 comments · Fixed by #1556
Closed

Screen turns off during video playback if there's no user input #1519

rom4nik opened this issue Oct 9, 2023 · 0 comments · Fixed by #1556
Assignees
@bmarty
Labels
A-Media Viewer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-UI-UX

Comments

@rom4nik
Copy link
Contributor

rom4nik commented Oct 9, 2023

Steps to reproduce

  1. Play a video longer than device's screen timeout
  2. Don't interact with device during playback

Outcome

What did you expect?

Screen stays on until video stops playing, then it can get dimmer/turn off if device is still idle.

What happened instead?

Screens gets dim and eventually turns off, pausing playback.

Your phone model

Google Pixel 3

Operating system version

Android 12

Application version and app store

096d575, debug build from GHA

Homeserver

Synapse 1.93.0

Will you send logs?

No

Are you willing to provide a PR?

No
@rom4nik rom4nik added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 9, 2023
@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely Z-UI-UX A-Media Viewer labels Oct 9, 2023
@bmarty bmarty self-assigned this Oct 12, 2023
bmarty added a commit that referenced this issue Oct 12, 2023
@bmarty
Ensure screen does not turn off when playing a video (#1519)
73a359e
bmarty added a commit that referenced this issue Oct 12, 2023
@bmarty
Ensure screen does not turn off when playing a video (#1519)
788627f
@bmarty bmarty mentioned this issue Oct 12, 2023
Merged
14 tasks
bmarty added a commit that referenced this issue Oct 12, 2023
@bmarty
Ensure screen does not turn off when playing a video (#1519)
c3bc44b
bmarty added a commit that referenced this issue Oct 13, 2023
@bmarty
Merge pull request #1556 from vector-im/feature/bma/videoLock
fee54ef 
Ensure screen does not turn off when playing a video (#1519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Media Viewer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-UI-UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure screen does not turn off when playing a video (#1519) element-hq/element-x-android
2 participants
@bmarty @rom4nik