-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where text is cleared when cancelling a reply #1617
Conversation
if (messageComposerContext.composerMode is MessageComposerMode.Edit) { | ||
localCoroutineScope.launch { | ||
richTextEditorState.setHtml("") | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the fix
c6cad54
to
0d094fa
Compare
Kudos, SonarCloud Quality Gate passed! |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1617 +/- ##
========================================
Coverage 58.98% 58.98%
========================================
Files 1225 1225
Lines 31619 31619
Branches 6493 6494 +1
========================================
Hits 18652 18652
Misses 10143 10143
Partials 2824 2824
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and for having added a test for it!
Type of change
Content
Fix issue where text is cleared when cancelling a reply.
Also remove redundant property on the
MessageComposerMode.Normal
class.Motivation and context
Screenshots / GIFs
N/A
Tests
Tested devices
Checklist