Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Voice messages] Add voice recording UI #1546

Merged
merged 10 commits into from
Oct 12, 2023
Merged

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Oct 11, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add UI for recording voice messages.

Includes some framework for later feature development e.g. presenter, tests, preview state provider.

Note this feature is only partially complete and there is no recording functionality. The feature is behind a feature flag enabled through developer options.

Motivation and context

Screenshots / GIFs

Screen_recording_20231011_131408.webm

Tests

  • Enable voice messages in developer options
  • Go to a room
  • Tap and hold record button
  • Type text and observe record button disappears

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew requested a review from a team as a code owner October 11, 2023 12:52
@jonnyandrew jonnyandrew requested review from jmartinesp and removed request for a team October 11, 2023 12:52
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (a2601c0) 59.04% compared to head (6ff3a3d) 59.11%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1546      +/-   ##
===========================================
+ Coverage    59.04%   59.11%   +0.06%     
===========================================
  Files         1167     1178      +11     
  Lines        30525    30729     +204     
  Branches      6248     6296      +48     
===========================================
+ Hits         18024    18165     +141     
- Misses        9802     9837      +35     
- Partials      2699     2727      +28     
Files Coverage Δ
...ndroid/features/messages/impl/MessagesPresenter.kt 82.60% <100.00%> (+0.79%) ⬆️
...nt/android/features/messages/impl/MessagesState.kt 100.00% <100.00%> (ø)
...id/features/messages/impl/MessagesStateProvider.kt 90.47% <100.00%> (+0.47%) ⬆️
...ent/android/features/messages/impl/MessagesView.kt 59.72% <100.00%> (+0.37%) ⬆️
...impl/messagecomposer/MessageComposerContextImpl.kt 100.00% <ø> (ø)
...ages/impl/messagecomposer/MessageComposerEvents.kt 100.00% <ø> (ø)
...s/impl/messagecomposer/MessageComposerPresenter.kt 92.93% <ø> (ø)
...sages/impl/messagecomposer/MessageComposerState.kt 100.00% <ø> (ø)
...pl/messagecomposer/MessageComposerStateProvider.kt 95.23% <ø> (ø)
...s/impl/voicemessages/VoiceMessageComposerEvents.kt 100.00% <100.00%> (ø)
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/SXGrmj

@bmarty bmarty requested review from bmarty and removed request for jmartinesp October 12, 2023 07:25
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks, else LGTM, nice work!

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonnyandrew jonnyandrew merged commit 12404fa into develop Oct 12, 2023
15 checks passed
@jonnyandrew jonnyandrew deleted the jonny/voice-record-ui branch October 12, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants