-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Voice messages] Add voice recording UI #1546
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1546 +/- ##
===========================================
+ Coverage 59.04% 59.11% +0.06%
===========================================
Files 1167 1178 +11
Lines 30525 30729 +204
Branches 6248 6296 +48
===========================================
+ Hits 18024 18165 +141
- Misses 9802 9837 +35
- Partials 2699 2727 +28
☔ View full report in Codecov by Sentry. |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small remarks, else LGTM, nice work!
.../kotlin/io/element/android/features/messages/impl/voicemessages/VoiceMessageComposerState.kt
Outdated
Show resolved
Hide resolved
...er/impl/src/main/kotlin/io/element/android/libraries/textcomposer/components/RecordButton.kt
Outdated
Show resolved
Hide resolved
...ser/impl/src/main/kotlin/io/element/android/libraries/textcomposer/utils/PressStateHolder.kt
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Type of change
Content
Add UI for recording voice messages.
Includes some framework for later feature development e.g. presenter, tests, preview state provider.
Note this feature is only partially complete and there is no recording functionality. The feature is behind a feature flag enabled through developer options.
Motivation and context
Screenshots / GIFs
Screen_recording_20231011_131408.webm
Tests
Tested devices
Checklist