Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konsist: add more test #1552

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Konsist: add more test #1552

merged 6 commits into from
Oct 12, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 12, 2023

Split existing Konsist test into multiple Test class and add new tests.

@bmarty bmarty requested a review from a team as a code owner October 12, 2023 08:48
@bmarty bmarty requested review from julioromano and removed request for a team October 12, 2023 08:48
@@ -20,5 +20,5 @@ import androidx.compose.ui.tooling.preview.PreviewParameterProvider

open class BooleanProvider : PreviewParameterProvider<Boolean> {
override val values: Sequence<Boolean>
get() = sequenceOf(false, true)
get() = sequenceOf(true, false)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorder to avoid breaking screenshot test (this was not used before)

@ElementBot
Copy link
Collaborator

ElementBot commented Oct 12, 2023

Warnings
⚠️

libraries/permissions/api/src/main/kotlin/io/element/android/libraries/permissions/api/PermissionsStateProvider.kt#L25 - Field requires API level 33 (current min is 23): android.Manifest.permission#POST_NOTIFICATIONS

⚠️

libraries/permissions/api/src/main/kotlin/io/element/android/libraries/permissions/api/PermissionsStateProvider.kt#L34 - Field requires API level 33 (current min is 23): android.Manifest.permission#POST_NOTIFICATIONS

Generated by 🚫 dangerJS against 634095c

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4H7oDf

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a2601c0) 59.04% compared to head (634095c) 59.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1552      +/-   ##
===========================================
+ Coverage    59.04%   59.06%   +0.01%     
===========================================
  Files         1167     1166       -1     
  Lines        30525    30518       -7     
  Branches      6248     6248              
===========================================
  Hits         18024    18024              
+ Misses        9802     9795       -7     
  Partials      2699     2699              
Files Coverage Δ
...ures/location/api/internal/StaticMapPlaceholder.kt 75.75% <ø> (-1.39%) ⬇️
...id/libraries/designsystem/utils/BooleanProvider.kt 100.00% <100.00%> (+100.00%) ⬆️
...raries/permissions/api/PermissionsStateProvider.kt 93.33% <100.00%> (ø)
...android/libraries/designsystem/components/Bloom.kt 74.20% <50.00%> (ø)
...droid/libraries/permissions/api/PermissionsView.kt 43.47% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty merged commit 13e8772 into develop Oct 12, 2023
16 checks passed
@bmarty bmarty deleted the feature/bma/konsist2 branch October 12, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants