Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure screen does not turn off when playing a video (#1519) #1556

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 12, 2023

Type of change

  • Feature
  • Bugfix / Enhancement
  • Technical
  • Other :

Content

Keep screen on while playing a video

Motivation and context

Fixes #1519

Screenshots / GIFs

Tests

  • Set timeout to 15s
  • Play a longer video with the app
  • Observe that the screen does not sleep.
  • Pause the playback -> the screen go to sleep after 15s

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner October 12, 2023 13:17
@bmarty bmarty requested review from julioromano and removed request for a team October 12, 2023 13:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QkPsac

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a2601c0) 59.04% compared to head (c3bc44b) 59.02%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1556      +/-   ##
===========================================
- Coverage    59.04%   59.02%   -0.02%     
===========================================
  Files         1167     1168       +1     
  Lines        30525    30536      +11     
  Branches      6248     6253       +5     
===========================================
+ Hits         18024    18025       +1     
- Misses        9802     9812      +10     
  Partials      2699     2699              
Files Coverage Δ
...s/messages/impl/media/local/LocalMediaViewState.kt 66.66% <100.00%> (+6.66%) ⬆️
...atures/messages/impl/media/local/LocalMediaView.kt 53.90% <0.00%> (-0.86%) ⬇️
...droid/libraries/designsystem/utils/KeepScreenOn.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty bmarty merged commit fee54ef into develop Oct 13, 2023
15 of 17 checks passed
@bmarty bmarty deleted the feature/bma/videoLock branch October 13, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen turns off during video playback if there's no user input
2 participants