Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Konsist tests to their own module #1558

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Move Konsist tests to their own module #1558

merged 3 commits into from
Oct 13, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 12, 2023

  • Move Konsist tests to their own module
  • Fix issue (merged today on develop, checked by previous version of Konsist tests)

The drawback is that dependencies will have to be added to the konsist module on-demand, for instance to check an annotation, a class, etc.

@bmarty bmarty requested a review from a team as a code owner October 12, 2023 16:48
@bmarty bmarty requested review from jmartinesp, julioromano and jonnyandrew and removed request for a team October 12, 2023 16:48
@ElementBot
Copy link
Collaborator

Warnings
⚠️

Please add a changelog. See instructions here
⚠️

You have made changes to a file containing a @Preview annotated function but its module doesn't include the showkase processor. Missing processor in: tests/konsist/build.gradle.kts
Messages
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against 3be6e65

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

julioromano
julioromano approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CooL!

@bmarty bmarty merged commit 18af57a into develop Oct 13, 2023
14 of 15 checks passed
@bmarty bmarty deleted the feature/bma/konsistTestLocation branch October 13, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julioromano julioromano julioromano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmarty @ElementBot @julioromano