Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SqlDelight to 2.0.0 #1569

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Migrate SqlDelight to 2.0.0 #1569

merged 3 commits into from
Oct 13, 2023

Conversation

julioromano
Copy link
Contributor

Closes #1557

@julioromano julioromano self-assigned this Oct 13, 2023
@julioromano julioromano requested a review from a team as a code owner October 13, 2023 13:18
@julioromano julioromano requested review from bmarty and removed request for a team October 13, 2023 13:18
@julioromano julioromano changed the title Julioromano/sqldelight2 Migrate SqlDelight to 2.0.0 Oct 13, 2023
@ElementBot
Copy link
Collaborator

ElementBot commented Oct 13, 2023 •
edited

Warnings
⚠️

Please add a changelog. See instructions here
Messages
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against 827d990

bmarty
bmarty approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@julioromano
Copy link
Contributor Author

LGTM, thanks!

Will merge as soon as I can rebase to make Konsist happy

@bmarty bmarty enabled auto-merge October 13, 2023 15:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty bmarty merged commit 27758b5 into develop Oct 13, 2023
13 checks passed
@bmarty bmarty deleted the julioromano/sqldelight2 branch October 13, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate SqlDelight to 2.0.0
3 participants
@julioromano @ElementBot @bmarty