Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue detected by Konsist. #1570

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix issue detected by Konsist. #1570

merged 2 commits into from
Oct 13, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 13, 2023

Fix 2 issues, due to new Konsist test merged on develop and branches merged on develop.

@bmarty bmarty requested a review from a team as a code owner October 13, 2023 13:46
@bmarty bmarty requested review from ganfra and removed request for a team October 13, 2023 13:46
@ElementBot
Copy link
Collaborator

ElementBot commented Oct 13, 2023

Warnings
⚠️

Please add a changelog. See instructions here

Messages
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against a3b2502

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/udNRyx

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 210 lines in your changes are missing coverage. Please review.

Comparison is base (7f65c13) 59.06% compared to head (a3b2502) 59.01%.
Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1570      +/-   ##
===========================================
- Coverage    59.06%   59.01%   -0.05%     
===========================================
  Files         1166     1192      +26     
  Lines        30518    30843     +325     
  Branches      6248     6338      +90     
===========================================
+ Hits         18024    18203     +179     
- Misses        9795     9896     +101     
- Partials      2699     2744      +45     
Files Coverage Δ
...ndroid/features/messages/impl/MessagesPresenter.kt 82.60% <100.00%> (+0.79%) ⬆️
...nt/android/features/messages/impl/MessagesState.kt 100.00% <100.00%> (ø)
...id/features/messages/impl/MessagesStateProvider.kt 90.47% <100.00%> (+0.47%) ⬆️
...ent/android/features/messages/impl/MessagesView.kt 59.72% <100.00%> (+0.37%) ⬆️
...s/messages/impl/media/local/LocalMediaViewState.kt 66.66% <100.00%> (+6.66%) ⬆️
...impl/messagecomposer/MessageComposerContextImpl.kt 100.00% <ø> (ø)
...ages/impl/messagecomposer/MessageComposerEvents.kt 100.00% <ø> (ø)
...s/impl/messagecomposer/MessageComposerPresenter.kt 92.93% <ø> (ø)
...sages/impl/messagecomposer/MessageComposerState.kt 100.00% <ø> (ø)
...pl/messagecomposer/MessageComposerStateProvider.kt 95.23% <ø> (ø)
... and 48 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty mentioned this pull request Oct 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty bmarty merged commit df8c4b6 into develop Oct 13, 2023
15 of 17 checks passed
@bmarty bmarty deleted the feature/bma/fixKonsist branch October 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants