Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Strings #1573

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Sync Strings #1573

merged 1 commit into from
Oct 16, 2023

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner October 16, 2023 00:09
@ElementBot ElementBot requested review from julioromano and removed request for a team October 16, 2023 00:09
@ElementBot
Copy link
Collaborator Author

ElementBot commented Oct 16, 2023

Warnings
⚠️

features/messages/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/messages/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

features/roomdetails/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

features/roomdetails/impl/src/main/res/values-ro/translations.xml#L3 - For locale "ro" (Romanian) the following quantity should also be defined: few (e.g. "2 zile")

⚠️

features/roomdetails/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L188 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L193 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L188 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L193 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 586a536

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zfAm1h

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7fc81ac) 59.01% compared to head (586a536) 59.01%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1573   +/-   ##
========================================
  Coverage    59.01%   59.01%           
========================================
  Files         1192     1192           
  Lines        30844    30844           
  Branches      6338     6338           
========================================
  Hits         18204    18204           
  Misses        9896     9896           
  Partials      2744     2744           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julioromano julioromano requested review from bmarty and removed request for julioromano October 16, 2023 06:23
@julioromano
Copy link
Contributor

@bmarty best if you review this as there seem to be lots of changes related to things you worked on.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, thanks @julioromano !

@bmarty bmarty merged commit c437301 into develop Oct 16, 2023
15 of 16 checks passed
@bmarty bmarty deleted the sync-localazy branch October 16, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants