Make sure Konsist tests always run #1590
Conversation
jmartinesp
force-pushed
the
misc/jme/fix-konsist-tests-not-running-on-check
branch
from
f410311
to
cb7e6d3
Compare
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
| // Make sure Konsist tests are always run | ||
| tasks.withType<Test>().configureEach { | ||
| outputs.upToDateWhen { false } | ||
| } |
There was a problem hiding this comment.
Konsist test are not always run because the konsist module does not depend on any other modules, except projects.libraries.architecture and projects.libraries.designsystem (see the lines above) because we need access to some external types.
Maybe add this in the comment above to explain why this patch is needed?
There was a problem hiding this comment.
Done in fb0bf38.
|
Added some changes to make sure Konsist tests are only run (and fail) in one flow, I'll remove the offending code later. EDIT: it works! Removing the commit that causes Konsist failures. |
jmartinesp
force-pushed
the
misc/jme/fix-konsist-tests-not-running-on-check
branch
from
fb0bf38
to
5b404c2
Compare
Co-authored-by: Benoit Marty <benoit@matrix.org>
|
Kudos, SonarCloud Quality Gate passed!
|
jmartinesp
deleted the
misc/jme/fix-konsist-tests-not-running-on-check
branch
Type of change
Content
This PR adds a workaround so Konsist tests are always run.
Motivation and context
Konsist tests weren't being run in either the CI or locally using gradle because all the tests were considered up to date. By setting the output as never up to date we make sure they're always run.
Tests