Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide keyboard when exiting the room screen #1593

Merged

Conversation

jmartinesp
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds a DisposableEffect to MessagesView so the keyboard is hidden when exiting the chat room screen. It seems to take a bit longer than usual, but at least it's hidden automatically.

Motivation and context

Fixes #1375.

Screenshots / GIFs

Screen_recording_20231018_132301.mp4

Tests

  • Open a room.
  • Tap on the message composer.
  • Navigate to other screen (back, to the room settings, to some user's profile, to view a media file, etc.).

The keyboard should be hidden automatically.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner October 18, 2023 11:24
@jmartinesp jmartinesp requested review from julioromano and removed request for a team October 18, 2023 11:24
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/K4CJgH

@ganfra
Copy link
Contributor

ganfra commented Oct 18, 2023

This is sloooooow, can we make it faster to close? :(

@jmartinesp
Copy link
Contributor Author

This is sloooooow, can we make it faster to close? :(

I think we'd have to find a way to trigger that view.hideKeyboard() when any node transition starts, instead of when it ends.

@jmartinesp
Copy link
Contributor Author

jmartinesp commented Oct 19, 2023

Merging this as is, since all the other solutions were a lot more complex. We'll revisit the issue in the future.

@jmartinesp jmartinesp merged commit 9aa4c59 into develop Oct 19, 2023
13 of 15 checks passed
@jmartinesp jmartinesp deleted the fix/jme/1375-hide-keyboard-when-exiting-room-screen branch October 19, 2023 08:49
bmarty added a commit that referenced this pull request Oct 20, 2023
bmarty added a commit that referenced this pull request Oct 20, 2023
Maestro No need to close the keyboard after fix from #1593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard stays up in front of the preview and buttons when sharing an image
3 participants