Add global context.cacheDir provider.

[julioromano]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Dagger now provides the app's cacheDir when requesting a @CacheDirectory File type.

Motivation and context

To support some upcoming code that needs the cacheDir to be changed during tests.

[bmarty]

LGTM, thanks!

[bmarty]

FTR this is what we had in EA: https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/di/FileQualifiers.kt#L31

@Qualifier
@Retention(AnnotationRetention.RUNTIME)
internal annotation class CacheDirectory

Maybe use the same name CacheDirectory. Also @Retention default value is AnnotationRetention.RUNTIME , so I think it's fine not to include it, but maybe @ganfra can confirm this?

[julioromano]

I just copied whatever we already had from @ApplicationContext.
As per the naming: I found it more "mnemonic" to have @CacheDir private val cacheDir: File and know that it will point to context.cacheDir.
But I'm open to better suggeestions.

[bmarty]

OK, it's fine. The PR is approved, you can merge it :)

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hV44uz

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (79d2941) 58.96% compared to head (a7f8da3) 58.96%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1606      +/-   ##
===========================================
- Coverage    58.96%   58.96%   -0.01%     
===========================================
  Files         1199     1199              
  Lines        30965    30966       +1     
  Branches      6343     6343              
===========================================
  Hits         18259    18259              
- Misses        9959     9960       +1     
  Partials      2747     2747              

Files	Coverage Δ
...c/main/kotlin/io/element/android/x/di/AppModule.kt	0.00% <0.00%> (ø)
...d/libraries/matrix/impl/RustMatrixClientFactory.kt	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[julioromano]

Renamed it and added docs to all existing qualifiers.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication