Feature/fga/pin create UI #1608
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1608 +/- ##
===========================================
+ Coverage 58.82% 58.96% +0.14%
===========================================
Files 1222 1226 +4
Lines 31438 31630 +192
Branches 6443 6494 +51
===========================================
+ Hits 18493 18652 +159
- Misses 10145 10154 +9
- Partials 2800 2824 +24
☔ View full report in Codecov by Sentry. |
| <string name="screen_app_lock_setup_confirm_pin">"Confirm PIN"</string> | ||
| <string name="screen_app_lock_setup_pin_blacklisted_dialog_content">"You cannot choose this as your PIN code for security reasons"</string> | ||
| <string name="screen_app_lock_setup_pin_blacklisted_dialog_title">"Choose a different PIN"</string> | ||
| <string name="screen_app_lock_setup_pin_context">"Lock Element to add extra security to your chats."</string> |
There was a problem hiding this comment.
We want to make the app name configurable I think
| <string name="screen_app_lock_setup_pin_context">"Lock Element to add extra security to your chats."</string> | |
| <string name="screen_app_lock_setup_pin_context">"Lock %s$1 to add extra security to your chats."</string> |
| <string name="screen_app_lock_settings_remove_pin">"Remove PIN"</string> | ||
| <string name="screen_app_lock_settings_remove_pin_alert_message">"Are you sure you want to remove PIN?"</string> | ||
| <string name="screen_app_lock_settings_remove_pin_alert_title">"Remove PIN?"</string> | ||
| <string name="screen_app_lock_setup_choose_pin">"Choose %1$d digit PIN"</string> |
There was a problem hiding this comment.
(maybe change to "Choose PIN" to fix this)
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> | ||
| <plurals name="screen_app_lock_subtitle_wrong_pin"> | ||
| <item quantity="one">"Wrong PIN. You have %1$d more chance"</item> |
There was a problem hiding this comment.
@amshakal do we want to put something more alarming here? We had this in EA currently, for the last attempt:
<string name="wrong_pin_message_last_remaining_attempt">Warning! Last remaining attempt before logout!</string>
There was a problem hiding this comment.
Good idea! Ill craft something a bit more alarming, thank you!
|
Kudos, SonarCloud Quality Gate passed!
|
First screen of the PIN creation flow.
There is no logic branched yet to save the pin.
Also I've not yet tested the interactions.
Figma : https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X?type=design&node-id=13067-150738